Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(telemetry): make logs less noisy and more clear #11853

Merged
merged 3 commits into from
Jan 8, 2025
Merged

chore(telemetry): make logs less noisy and more clear #11853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef46d1a
chore(telemetry): make logs less noisy and more clear
mabdinur Jan 3, 2025
9b9cd50
Merge branch 'main' into munir/make-telemetry-less-noisy
mabdinur Jan 6, 2025
5dad21a
Merge branch 'main' into munir/make-telemetry-less-noisy
mabdinur Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ddtrace/internal/telemetry/writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,17 @@ def send_event(self, request: Dict) -> Optional[httplib.HTTPResponse]:
conn.request("POST", self._endpoint, rb_json, headers)
resp = get_connection_response(conn)
if resp.status < 300:
log.debug("sent %d in %.5fs to %s. response: %s", len(rb_json), sw.elapsed(), self.url, resp.status)
log.debug(
"Instrumentation Telemetry sent %d in %.5fs to %s. response: %s",
len(rb_json),
sw.elapsed(),
self.url,
resp.status,
)
else:
log.debug("failed to send telemetry to %s. response: %s", self.url, resp.status)
except Exception:
log.debug("failed to send telemetry to %s.", self.url, exc_info=True)
log.debug("Failed to send Instrumentation Telemetry to %s. response: %s", self.url, resp.status)
except Exception as e:
log.debug("Failed to send Instrumentation Telemetry to %s. Error: %s", self.url, str(e))
finally:
if conn is not None:
conn.close()
Expand Down
2 changes: 1 addition & 1 deletion tests/telemetry/test_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,7 @@ def test_send_failing_request(mock_status, telemetry_writer):
telemetry_writer.periodic(force_flush=True)
# asserts unsuccessful status code was logged
log.debug.assert_called_with(
"failed to send telemetry to %s. response: %s",
"Failed to send Instrumentation Telemetry to %s. response: %s",
telemetry_writer._client.url,
mock_status,
)
Expand Down
Loading