Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(telemetry): make logs less noisy and more clear #11853

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jan 3, 2025

Partially Resolves: #10842

  • Removes exception traceback from telemetry client logs. We should not generate a traceback everytime we fail to send telemetry payloads to the agent. This traceback is noisy and not actionable.
  • Updates telemetry client log message to clearly state that instrumentation telemetry failed to send and not user telemetry (ex: traces, logs, metrics).

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Jan 3, 2025

CODEOWNERS have been resolved as:

ddtrace/internal/telemetry/writer.py                                    @DataDog/apm-core-python
tests/telemetry/test_writer.py                                          @DataDog/apm-python

@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 3, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jan 3, 2025

Benchmarks

Benchmark execution time: 2025-01-06 19:44:28

Comparing candidate commit 9b9cd50 in PR branch munir/make-telemetry-less-noisy with baseline commit 81208cd in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@mabdinur mabdinur marked this pull request as ready for review January 3, 2025 16:11
@mabdinur mabdinur requested review from a team as code owners January 3, 2025 16:11
@mabdinur mabdinur enabled auto-merge (squash) January 6, 2025 19:04
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 6, 2025

Datadog Report

Branch report: munir/make-telemetry-less-noisy
Commit report: 5dad21a
Test service: dd-trace-py

✅ 0 Failed, 87 Passed, 1468 Skipped, 4m 11.53s Total duration (35m 20.98s time saved)

@mabdinur mabdinur merged commit 33b2499 into main Jan 8, 2025
176 checks passed
@mabdinur mabdinur deleted the munir/make-telemetry-less-noisy branch January 8, 2025 17:36
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
Partially Resolves: #10842

- Removes exception traceback from telemetry client logs. We should not
generate a traceback everytime we fail to send telemetry payloads to the
agent. This traceback is noisy and not actionable.
- Updates telemetry client log message to clearly state that
instrumentation telemetry failed to send and not user telemetry (ex:
traces, logs, metrics).

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 33b2499)
emmettbutler added a commit that referenced this pull request Jan 9, 2025
…#11876)

Backport 33b2499 from #11853 to 2.19.

Partially Resolves: #10842

- Removes exception traceback from telemetry client logs. We should not
generate a traceback everytime we fail to send telemetry payloads to the
agent. This traceback is noisy and not actionable.
- Updates telemetry client log message to clearly state that
instrumentation telemetry failed to send and not user telemetry (ex:
traces, logs, metrics).

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Munir Abdinur <[email protected]>
Co-authored-by: Emmett Butler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.19 changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AgentWriter exception became visible in 2.11.0 version
2 participants