Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add schematize service name for django caching #11843

Merged
merged 9 commits into from
Jan 2, 2025

Conversation

quinna-h
Copy link
Contributor

@quinna-h quinna-h commented Dec 30, 2024

Currently, we treat django caching as a separate service.
This is a quick fix so that behavior aligns with our public docs; inferred services connected to django should be directly connected to the third-party service not django.
The service name should adhere to the name rule from schematize_service_name rather than django.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Dec 30, 2024

CODEOWNERS have been resolved as:

releasenotes/notes/django-cache-service-name-schematization-bef19b44b7414016.yaml  @DataDog/apm-python
ddtrace/contrib/internal/django/patch.py                                @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/django/test_django.py                                     @DataDog/apm-core-python @DataDog/apm-idm-python

@quinna-h quinna-h marked this pull request as ready for review December 30, 2024 18:08
@quinna-h quinna-h requested review from a team as code owners December 30, 2024 18:08
@quinna-h quinna-h marked this pull request as draft December 30, 2024 18:08
@quinna-h quinna-h changed the title add schematize service name for django caching fix: add schematize service name for django caching Dec 30, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Dec 30, 2024

Datadog Report

Branch report: django-cache-service-name
Commit report: 1b2be7e
Test service: dd-trace-py

✅ 0 Failed, 289 Passed, 1179 Skipped, 8m 47.95s Total duration (27m 34.96s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Dec 30, 2024

Benchmarks

Benchmark execution time: 2025-01-02 15:54:29

Comparing candidate commit 71a7f0b in PR branch django-cache-service-name with baseline commit 998ee2c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 374 metrics, 2 unstable metrics.

@quinna-h quinna-h marked this pull request as ready for review December 30, 2024 22:29
@quinna-h quinna-h requested a review from a team as a code owner December 30, 2024 22:29
update tests

wip

update test

add test
@quinna-h quinna-h force-pushed the django-cache-service-name branch from a20be80 to d94eecd Compare December 30, 2024 22:34
Co-authored-by: erikayasuda <[email protected]>
Copy link
Contributor

@wconti27 wconti27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just need to address a few nits

@quinna-h quinna-h enabled auto-merge (squash) January 2, 2025 15:17
@quinna-h quinna-h merged commit 6613185 into main Jan 2, 2025
588 checks passed
@quinna-h quinna-h deleted the django-cache-service-name branch January 2, 2025 15:56
github-actions bot pushed a commit that referenced this pull request Jan 3, 2025
Currently, we treat django caching as a separate service.
This is a quick fix so that behavior aligns with our public docs;
inferred services connected to django should be directly connected to
the third-party service not django.
The service name should adhere to the name rule from
`schematize_service_name` rather than `django`.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Munir Abdinur <[email protected]>
Co-authored-by: erikayasuda <[email protected]>
(cherry picked from commit 6613185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants