-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add schematize service name for django caching #11843
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 289 Passed, 1179 Skipped, 8m 47.95s Total duration (27m 34.96s time saved) |
BenchmarksBenchmark execution time: 2025-01-02 15:54:29 Comparing candidate commit 71a7f0b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 374 metrics, 2 unstable metrics. |
update tests wip update test add test
a20be80
to
d94eecd
Compare
releasenotes/notes/django-cache-service-name-schematization-bef19b44b7414016.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: erikayasuda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just need to address a few nits
releasenotes/notes/django-cache-service-name-schematization-bef19b44b7414016.yaml
Outdated
Show resolved
Hide resolved
Currently, we treat django caching as a separate service. This is a quick fix so that behavior aligns with our public docs; inferred services connected to django should be directly connected to the third-party service not django. The service name should adhere to the name rule from `schematize_service_name` rather than `django`. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Munir Abdinur <[email protected]> Co-authored-by: erikayasuda <[email protected]> (cherry picked from commit 6613185)
Currently, we treat django caching as a separate service.
This is a quick fix so that behavior aligns with our public docs; inferred services connected to django should be directly connected to the third-party service not django.
The service name should adhere to the name rule from
schematize_service_name
rather thandjango
.Checklist
Reviewer Checklist