Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add schematize service name for django caching [backport 2.19] #11854

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 3, 2025

Backport 6613185 from #11843 to 2.19.

Currently, we treat django caching as a separate service.
This is a quick fix so that behavior aligns with our public docs; inferred services connected to django should be directly connected to the third-party service not django.
The service name should adhere to the name rule from schematize_service_name rather than django.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Currently, we treat django caching as a separate service.
This is a quick fix so that behavior aligns with our public docs;
inferred services connected to django should be directly connected to
the third-party service not django.
The service name should adhere to the name rule from
`schematize_service_name` rather than `django`.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Munir Abdinur <[email protected]>
Co-authored-by: erikayasuda <[email protected]>
(cherry picked from commit 6613185)
@pr-commenter
Copy link

pr-commenter bot commented Jan 3, 2025

Benchmarks

Benchmark execution time: 2025-01-16 18:23:07

Comparing candidate commit 8e5bf1d in PR branch backport-11843-to-2.19 with baseline commit e16d68c in branch 2.19.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 378 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathdirname_aspect

  • 🟩 execution_time [-454.075ns; -387.331ns] or [-11.006%; -9.388%]

scenario:iast_aspects-ospathsplitext_aspect

  • 🟩 execution_time [-349.242ns; -288.777ns] or [-8.874%; -7.338%]

@mabdinur mabdinur enabled auto-merge (squash) January 6, 2025 19:17
Copy link
Contributor Author

CODEOWNERS have been resolved as:

releasenotes/notes/django-cache-service-name-schematization-bef19b44b7414016.yaml  @DataDog/apm-python
ddtrace/contrib/internal/django/patch.py                                @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/django/test_django.py                                     @DataDog/apm-core-python @DataDog/apm-idm-python

@mabdinur mabdinur merged commit ad2dc85 into 2.19 Jan 16, 2025
570 checks passed
@mabdinur mabdinur deleted the backport-11843-to-2.19 branch January 16, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants