fix aws request/response payload tagging #9887
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎯 Code Coverage 🔗 Commit SHA: 3853fb5 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~3853fb5380, baseline=1.56.0-SNAPSHOT~f132c86c16
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048449
Total [baseline] (8.601 s) : 0, 8600907
Agent [candidate] (1.056 s) : 0, 1055759
Total [candidate] (8.649 s) : 0, 8649462
section iast
Agent [baseline] (1.178 s) : 0, 1178336
Total [baseline] (9.25 s) : 0, 9250471
Agent [candidate] (1.177 s) : 0, 1176997
Total [candidate] (9.249 s) : 0, 9248905
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~3853fb5380, baseline=1.56.0-SNAPSHOT~f132c86c16
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (706.065 ms) : 0, 706065
BytebuddyAgent [candidate] (711.11 ms) : 0, 711110
GlobalTracer [baseline] (245.885 ms) : 0, 245885
GlobalTracer [candidate] (247.61 ms) : 0, 247610
AppSec [baseline] (32.438 ms) : 0, 32438
AppSec [candidate] (32.542 ms) : 0, 32542
Debugger [baseline] (6.431 ms) : 0, 6431
Debugger [candidate] (6.429 ms) : 0, 6429
Remote Config [baseline] (713.249 µs) : 0, 713
Remote Config [candidate] (702.349 µs) : 0, 702
Telemetry [baseline] (13.479 ms) : 0, 13479
Telemetry [candidate] (13.778 ms) : 0, 13778
Flare Poller [baseline] (7.333 ms) : 0, 7333
Flare Poller [candidate] (7.322 ms) : 0, 7322
section iast
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (827.932 ms) : 0, 827932
BytebuddyAgent [candidate] (827.247 ms) : 0, 827247
GlobalTracer [baseline] (234.358 ms) : 0, 234358
GlobalTracer [candidate] (233.972 ms) : 0, 233972
IAST [baseline] (34.946 ms) : 0, 34946
IAST [candidate] (34.039 ms) : 0, 34039
AppSec [baseline] (26.021 ms) : 0, 26021
AppSec [candidate] (26.753 ms) : 0, 26753
Debugger [baseline] (6.012 ms) : 0, 6012
Debugger [candidate] (5.943 ms) : 0, 5943
Remote Config [baseline] (603.777 µs) : 0, 604
Remote Config [candidate] (598.918 µs) : 0, 599
Telemetry [baseline] (8.34 ms) : 0, 8340
Telemetry [candidate] (8.306 ms) : 0, 8306
Flare Poller [baseline] (4.054 ms) : 0, 4054
Flare Poller [candidate] (4.132 ms) : 0, 4132
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~3853fb5380, baseline=1.56.0-SNAPSHOT~f132c86c16
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047109
Total [baseline] (10.802 s) : 0, 10801571
Agent [candidate] (1.047 s) : 0, 1046967
Total [candidate] (10.689 s) : 0, 10689361
section appsec
Agent [baseline] (1.224 s) : 0, 1224084
Total [baseline] (10.873 s) : 0, 10873423
Agent [candidate] (1.222 s) : 0, 1222434
Total [candidate] (10.839 s) : 0, 10839325
section iast
Agent [baseline] (1.181 s) : 0, 1180875
Total [baseline] (11.135 s) : 0, 11135223
Agent [candidate] (1.181 s) : 0, 1181283
Total [candidate] (11.123 s) : 0, 11122530
section profiling
Agent [baseline] (1.204 s) : 0, 1203541
Total [baseline] (10.91 s) : 0, 10910013
Agent [candidate] (1.194 s) : 0, 1194100
Total [candidate] (10.896 s) : 0, 10895967
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~3853fb5380, baseline=1.56.0-SNAPSHOT~f132c86c16
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (705.203 ms) : 0, 705203
BytebuddyAgent [candidate] (704.851 ms) : 0, 704851
GlobalTracer [baseline] (245.715 ms) : 0, 245715
GlobalTracer [candidate] (245.982 ms) : 0, 245982
AppSec [baseline] (32.289 ms) : 0, 32289
AppSec [candidate] (32.434 ms) : 0, 32434
Debugger [baseline] (6.38 ms) : 0, 6380
Debugger [candidate] (6.4 ms) : 0, 6400
Remote Config [baseline] (707.482 µs) : 0, 707
Remote Config [candidate] (705.232 µs) : 0, 705
Telemetry [baseline] (15.72 ms) : 0, 15720
Telemetry [candidate] (13.877 ms) : 0, 13877
Flare Poller [baseline] (4.938 ms) : 0, 4938
Flare Poller [candidate] (6.565 ms) : 0, 6565
section appsec
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (730.548 ms) : 0, 730548
BytebuddyAgent [candidate] (729.732 ms) : 0, 729732
GlobalTracer [baseline] (238.096 ms) : 0, 238096
GlobalTracer [candidate] (237.271 ms) : 0, 237271
IAST [baseline] (24.826 ms) : 0, 24826
IAST [candidate] (24.79 ms) : 0, 24790
AppSec [baseline] (174.956 ms) : 0, 174956
AppSec [candidate] (175.099 ms) : 0, 175099
Debugger [baseline] (6.003 ms) : 0, 6003
Debugger [candidate] (6.0 ms) : 0, 6000
Remote Config [baseline] (653.946 µs) : 0, 654
Remote Config [candidate] (651.703 µs) : 0, 652
Telemetry [baseline] (8.628 ms) : 0, 8628
Telemetry [candidate] (8.625 ms) : 0, 8625
Flare Poller [baseline] (3.997 ms) : 0, 3997
Flare Poller [candidate] (4.006 ms) : 0, 4006
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (829.365 ms) : 0, 829365
BytebuddyAgent [candidate] (828.555 ms) : 0, 828555
GlobalTracer [baseline] (235.212 ms) : 0, 235212
GlobalTracer [candidate] (236.075 ms) : 0, 236075
IAST [baseline] (34.157 ms) : 0, 34157
IAST [candidate] (34.991 ms) : 0, 34991
AppSec [baseline] (26.791 ms) : 0, 26791
AppSec [candidate] (26.267 ms) : 0, 26267
Debugger [baseline] (6.015 ms) : 0, 6015
Debugger [candidate] (6.028 ms) : 0, 6028
Remote Config [baseline] (597.88 µs) : 0, 598
Remote Config [candidate] (602.941 µs) : 0, 603
Telemetry [baseline] (8.373 ms) : 0, 8373
Telemetry [candidate] (8.341 ms) : 0, 8341
Flare Poller [baseline] (4.117 ms) : 0, 4117
Flare Poller [candidate] (4.159 ms) : 0, 4159
section profiling
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.435 ms) : 0, 1435
BytebuddyAgent [baseline] (735.764 ms) : 0, 735764
BytebuddyAgent [candidate] (730.526 ms) : 0, 730526
GlobalTracer [baseline] (223.403 ms) : 0, 223403
GlobalTracer [candidate] (221.78 ms) : 0, 221780
AppSec [baseline] (32.505 ms) : 0, 32505
AppSec [candidate] (31.989 ms) : 0, 31989
Debugger [baseline] (6.768 ms) : 0, 6768
Debugger [candidate] (7.461 ms) : 0, 7461
Remote Config [baseline] (1.554 ms) : 0, 1554
Remote Config [candidate] (682.343 µs) : 0, 682
Telemetry [baseline] (15.348 ms) : 0, 15348
Telemetry [candidate] (15.421 ms) : 0, 15421
Flare Poller [baseline] (4.15 ms) : 0, 4150
Flare Poller [candidate] (4.106 ms) : 0, 4106
ProfilingAgent [baseline] (112.202 ms) : 0, 112202
ProfilingAgent [candidate] (110.712 ms) : 0, 110712
Profiling [baseline] (112.881 ms) : 0, 112881
Profiling [candidate] (111.378 ms) : 0, 111378
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~3853fb5380, baseline=1.56.0-SNAPSHOT~f132c86c16
dateFormat X
axisFormat %s
section baseline
no_agent (18.846 ms) : 18654, 19037
. : milestone, 18846,
appsec (18.389 ms) : 18202, 18576
. : milestone, 18389,
code_origins (17.844 ms) : 17664, 18023
. : milestone, 17844,
iast (17.817 ms) : 17641, 17993
. : milestone, 17817,
profiling (18.61 ms) : 18422, 18799
. : milestone, 18610,
tracing (17.655 ms) : 17481, 17830
. : milestone, 17655,
section candidate
no_agent (18.179 ms) : 17993, 18366
. : milestone, 18179,
appsec (18.515 ms) : 18327, 18704
. : milestone, 18515,
code_origins (17.838 ms) : 17662, 18013
. : milestone, 17838,
iast (17.499 ms) : 17327, 17671
. : milestone, 17499,
profiling (18.667 ms) : 18475, 18859
. : milestone, 18667,
tracing (17.589 ms) : 17414, 17765
. : milestone, 17589,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~3853fb5380, baseline=1.56.0-SNAPSHOT~f132c86c16
dateFormat X
axisFormat %s
section baseline
no_agent (1.201 ms) : 1189, 1213
. : milestone, 1201,
iast (3.176 ms) : 3136, 3216
. : milestone, 3176,
iast_FULL (5.71 ms) : 5653, 5767
. : milestone, 5710,
iast_GLOBAL (3.614 ms) : 3555, 3673
. : milestone, 3614,
profiling (2.087 ms) : 2065, 2109
. : milestone, 2087,
tracing (1.798 ms) : 1782, 1814
. : milestone, 1798,
section candidate
no_agent (1.21 ms) : 1197, 1223
. : milestone, 1210,
iast (3.25 ms) : 3205, 3295
. : milestone, 3250,
iast_FULL (5.786 ms) : 5728, 5844
. : milestone, 5786,
iast_GLOBAL (3.66 ms) : 3606, 3713
. : milestone, 3660,
profiling (2.058 ms) : 2040, 2076
. : milestone, 2058,
tracing (1.82 ms) : 1805, 1835
. : milestone, 1820,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~3853fb5380, baseline=1.56.0-SNAPSHOT~f132c86c16
dateFormat X
axisFormat %s
section baseline
no_agent (14.967 s) : 14967000, 14967000
. : milestone, 14967000,
appsec (14.81 s) : 14810000, 14810000
. : milestone, 14810000,
iast (18.1 s) : 18100000, 18100000
. : milestone, 18100000,
iast_GLOBAL (18.08 s) : 18080000, 18080000
. : milestone, 18080000,
profiling (15.578 s) : 15578000, 15578000
. : milestone, 15578000,
tracing (14.76 s) : 14760000, 14760000
. : milestone, 14760000,
section candidate
no_agent (15.135 s) : 15135000, 15135000
. : milestone, 15135000,
appsec (15.01 s) : 15010000, 15010000
. : milestone, 15010000,
iast (18.554 s) : 18554000, 18554000
. : milestone, 18554000,
iast_GLOBAL (17.925 s) : 17925000, 17925000
. : milestone, 17925000,
profiling (14.85 s) : 14850000, 14850000
. : milestone, 14850000,
tracing (14.823 s) : 14823000, 14823000
. : milestone, 14823000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~3853fb5380, baseline=1.56.0-SNAPSHOT~f132c86c16
dateFormat X
axisFormat %s
section baseline
no_agent (1.487 ms) : 1475, 1499
. : milestone, 1487,
appsec (3.72 ms) : 3501, 3940
. : milestone, 3720,
iast (2.223 ms) : 2159, 2286
. : milestone, 2223,
iast_GLOBAL (2.266 ms) : 2202, 2330
. : milestone, 2266,
profiling (2.069 ms) : 2017, 2120
. : milestone, 2069,
tracing (2.031 ms) : 1982, 2081
. : milestone, 2031,
section candidate
no_agent (1.486 ms) : 1475, 1498
. : milestone, 1486,
appsec (3.727 ms) : 3507, 3947
. : milestone, 3727,
iast (2.221 ms) : 2157, 2285
. : milestone, 2221,
iast_GLOBAL (2.266 ms) : 2203, 2330
. : milestone, 2266,
profiling (2.076 ms) : 2025, 2128
. : milestone, 2076,
tracing (2.032 ms) : 1983, 2082
. : milestone, 2032,
|
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
mhlidd
reviewed
Oct 30, 2025
Contributor
mhlidd
left a comment
mhlidd
left a comment
There was a problem hiding this comment.
General Question: If the config is set to a non-JSON-path value, or not "all", should the feature be turned off in the Config class?
ojproductions
added
type: enhancement
Author
|
@mhlidd, if we are to take the official documentation literally, the only time payload tagging is disabled is when the variables are empty or omitted. I do see how this could be misleading though because you can effectively turn on payload tagging by adding any value even if it is not "all". How I see it though, the paths are subtractive rather than additive. Meaning, default is to show every field, and for every valid path added, we show 1 less field. If the path is invalid its ignored |
Contributor
Just want to make sure that this is aligned with the spec. From the spec, I see the following:
This seems a little contradictory to the behavior we see in the tracer. While the redaction behavior would not be turned on unless the JSON paths passed in are valid, the configs are still when adding AWS span tags at some point. ❓ Does the RFC spec mean that we want the span tag behavior to also be disabled when non-valid JSON paths are set for the environment variables. If so, we may need to modify the logic of verifying the logic of handling the Environment Variable values. |
Author
|
I think this comes down to which source of truth we want to honor – the spec or the public documentation on datadog website. I believe @joeyzhao2018 (author of the spec) also decided to follow the public doc (but correct me if I'm wrong Joey. Either way we should update the spec accordingly) |
Contributor
|
@ojproductions To clarify. The public documentation specified clearly on three types of values, i.e. JSON PATH, "all" and empty( or double quotes ""). It did NOT clearly state the expected behavior of any other values such as "false" "off". IMHO, treating those values as ON and tell the customers that our doc only mentioned "" as the official accepted value is not ideal. Therefore I still think it should be off. |
ojproductions
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Specifically in the lambda environment, users (or some instrumenation helpers such as datadog-cdk-constructs) may add the env without adding any value so that it defaults to disabled.
This is to make the feature visible for discovery purposes, but without forcing it as a default
read more here
APMSVLS-53