-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude flaky errors from error log checks #8123
Draft
smola
wants to merge
1
commit into
master
Choose a base branch
from
smola/add-error-log-exclusions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+23
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smola
added
comp: testing
Testing
tag: no release notes
Changes to exclude from release notes
run-tests: all
Run all tests
labels
Dec 20, 2024
smola
force-pushed
the
smola/add-error-log-exclusions
branch
from
December 20, 2024 16:32
bc6f306
to
dac2889
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~dac2889c6e, baseline=1.45.0-SNAPSHOT~a3e9bda406
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1053268
Total [baseline] (10.469 s) : 0, 10469468
Agent [candidate] (1.054 s) : 0, 1054202
Total [candidate] (10.388 s) : 0, 10388482
section appsec
Agent [baseline] (1.186 s) : 0, 1185640
Total [baseline] (10.749 s) : 0, 10749425
Agent [candidate] (1.184 s) : 0, 1183923
Total [candidate] (10.666 s) : 0, 10665736
section iast
Agent [baseline] (1.179 s) : 0, 1179149
Total [baseline] (10.907 s) : 0, 10906793
Agent [candidate] (1.177 s) : 0, 1177221
Total [candidate] (10.893 s) : 0, 10892683
section profiling
Agent [baseline] (1.277 s) : 0, 1277209
Total [baseline] (10.832 s) : 0, 10832094
Agent [candidate] (1.274 s) : 0, 1274477
Total [candidate] (10.83 s) : 0, 10830364
gantt
title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~dac2889c6e, baseline=1.45.0-SNAPSHOT~a3e9bda406
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (711.734 ms) : 0, 711734
BytebuddyAgent [candidate] (712.134 ms) : 0, 712134
GlobalTracer [baseline] (255.582 ms) : 0, 255582
GlobalTracer [candidate] (255.893 ms) : 0, 255893
AppSec [baseline] (58.46 ms) : 0, 58460
AppSec [candidate] (57.919 ms) : 0, 57919
Remote Config [baseline] (688.84 µs) : 0, 689
Remote Config [candidate] (695.356 µs) : 0, 695
Telemetry [baseline] (11.843 ms) : 0, 11843
Telemetry [candidate] (12.59 ms) : 0, 12590
section appsec
BytebuddyAgent [baseline] (728.754 ms) : 0, 728754
BytebuddyAgent [candidate] (727.465 ms) : 0, 727465
GlobalTracer [baseline] (252.532 ms) : 0, 252532
GlobalTracer [candidate] (252.221 ms) : 0, 252221
AppSec [baseline] (171.135 ms) : 0, 171135
AppSec [candidate] (171.091 ms) : 0, 171091
IAST [baseline] (19.311 ms) : 0, 19311
IAST [candidate] (19.292 ms) : 0, 19292
Remote Config [baseline] (662.21 µs) : 0, 662
Remote Config [candidate] (652.95 µs) : 0, 653
Telemetry [baseline] (7.992 ms) : 0, 7992
Telemetry [candidate] (7.941 ms) : 0, 7941
section iast
BytebuddyAgent [baseline] (829.747 ms) : 0, 829747
BytebuddyAgent [candidate] (828.085 ms) : 0, 828085
GlobalTracer [baseline] (246.603 ms) : 0, 246603
GlobalTracer [candidate] (245.895 ms) : 0, 245895
AppSec [baseline] (57.771 ms) : 0, 57771
AppSec [candidate] (57.738 ms) : 0, 57738
IAST [baseline] (21.118 ms) : 0, 21118
IAST [candidate] (21.412 ms) : 0, 21412
Remote Config [baseline] (649.223 µs) : 0, 649
Remote Config [candidate] (653.761 µs) : 0, 654
Telemetry [baseline] (8.441 ms) : 0, 8441
Telemetry [candidate] (8.408 ms) : 0, 8408
section profiling
BytebuddyAgent [baseline] (704.068 ms) : 0, 704068
BytebuddyAgent [candidate] (702.704 ms) : 0, 702704
GlobalTracer [baseline] (372.429 ms) : 0, 372429
GlobalTracer [candidate] (371.373 ms) : 0, 371373
AppSec [baseline] (54.057 ms) : 0, 54057
AppSec [candidate] (53.913 ms) : 0, 53913
Remote Config [baseline] (657.415 µs) : 0, 657
Remote Config [candidate] (665.877 µs) : 0, 666
Telemetry [baseline] (8.04 ms) : 0, 8040
Telemetry [candidate] (7.817 ms) : 0, 7817
ProfilingAgent [baseline] (96.151 ms) : 0, 96151
ProfilingAgent [candidate] (96.231 ms) : 0, 96231
Profiling [baseline] (96.177 ms) : 0, 96177
Profiling [candidate] (96.255 ms) : 0, 96255
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~dac2889c6e, baseline=1.45.0-SNAPSHOT~a3e9bda406
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052126
Total [baseline] (8.601 s) : 0, 8601049
Agent [candidate] (1.053 s) : 0, 1052799
Total [candidate] (8.603 s) : 0, 8602884
section iast
Agent [baseline] (1.178 s) : 0, 1178371
Total [baseline] (9.215 s) : 0, 9214894
Agent [candidate] (1.177 s) : 0, 1177417
Total [candidate] (9.231 s) : 0, 9231061
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.184 s) : 0, 1183964
Total [baseline] (9.171 s) : 0, 9171369
Agent [candidate] (1.177 s) : 0, 1176990
Total [candidate] (9.199 s) : 0, 9198978
section iast_TELEMETRY_OFF
Agent [baseline] (1.175 s) : 0, 1175041
Total [baseline] (9.171 s) : 0, 9170536
Agent [candidate] (1.172 s) : 0, 1171651
Total [candidate] (9.156 s) : 0, 9156307
gantt
title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~dac2889c6e, baseline=1.45.0-SNAPSHOT~a3e9bda406
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (711.099 ms) : 0, 711099
BytebuddyAgent [candidate] (711.243 ms) : 0, 711243
GlobalTracer [baseline] (255.09 ms) : 0, 255090
GlobalTracer [candidate] (256.172 ms) : 0, 256172
AppSec [baseline] (58.572 ms) : 0, 58572
AppSec [candidate] (57.985 ms) : 0, 57985
Remote Config [baseline] (687.341 µs) : 0, 687
Remote Config [candidate] (685.839 µs) : 0, 686
Telemetry [baseline] (11.814 ms) : 0, 11814
Telemetry [candidate] (11.791 ms) : 0, 11791
section iast
BytebuddyAgent [baseline] (827.898 ms) : 0, 827898
BytebuddyAgent [candidate] (828.049 ms) : 0, 828049
GlobalTracer [baseline] (247.086 ms) : 0, 247086
GlobalTracer [candidate] (246.43 ms) : 0, 246430
AppSec [baseline] (57.899 ms) : 0, 57899
AppSec [candidate] (57.59 ms) : 0, 57590
IAST [baseline] (21.346 ms) : 0, 21346
IAST [candidate] (21.272 ms) : 0, 21272
Remote Config [baseline] (683.88 µs) : 0, 684
Remote Config [candidate] (689.507 µs) : 0, 690
Telemetry [baseline] (8.55 ms) : 0, 8550
Telemetry [candidate] (8.459 ms) : 0, 8459
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (832.935 ms) : 0, 832935
BytebuddyAgent [candidate] (826.22 ms) : 0, 826220
GlobalTracer [baseline] (247.782 ms) : 0, 247782
GlobalTracer [candidate] (247.507 ms) : 0, 247507
AppSec [baseline] (58.035 ms) : 0, 58035
AppSec [candidate] (57.883 ms) : 0, 57883
IAST [baseline] (21.087 ms) : 0, 21087
IAST [candidate] (21.237 ms) : 0, 21237
Remote Config [baseline] (650.305 µs) : 0, 650
Remote Config [candidate] (655.379 µs) : 0, 655
Telemetry [baseline] (8.466 ms) : 0, 8466
Telemetry [candidate] (8.548 ms) : 0, 8548
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (825.695 ms) : 0, 825695
BytebuddyAgent [candidate] (823.346 ms) : 0, 823346
GlobalTracer [baseline] (246.959 ms) : 0, 246959
GlobalTracer [candidate] (246.345 ms) : 0, 246345
AppSec [baseline] (57.782 ms) : 0, 57782
AppSec [candidate] (57.609 ms) : 0, 57609
IAST [baseline] (20.788 ms) : 0, 20788
IAST [candidate] (20.485 ms) : 0, 20485
Remote Config [baseline] (647.555 µs) : 0, 648
Remote Config [candidate] (631.215 µs) : 0, 631
Telemetry [baseline] (8.315 ms) : 0, 8315
Telemetry [candidate] (8.266 ms) : 0, 8266
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~dac2889c6e, baseline=1.45.0-SNAPSHOT~a3e9bda406
dateFormat X
axisFormat %s
section baseline
no_agent (1.366 ms) : 1347, 1385
. : milestone, 1366,
appsec (1.752 ms) : 1729, 1776
. : milestone, 1752,
appsec_no_iast (1.786 ms) : 1762, 1810
. : milestone, 1786,
iast (1.508 ms) : 1484, 1531
. : milestone, 1508,
profiling (1.53 ms) : 1504, 1556
. : milestone, 1530,
tracing (1.486 ms) : 1461, 1512
. : milestone, 1486,
section candidate
no_agent (1.363 ms) : 1343, 1383
. : milestone, 1363,
appsec (1.765 ms) : 1742, 1789
. : milestone, 1765,
appsec_no_iast (1.777 ms) : 1753, 1802
. : milestone, 1777,
iast (1.511 ms) : 1487, 1534
. : milestone, 1511,
profiling (1.562 ms) : 1537, 1587
. : milestone, 1562,
tracing (1.492 ms) : 1467, 1516
. : milestone, 1492,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~dac2889c6e, baseline=1.45.0-SNAPSHOT~a3e9bda406
dateFormat X
axisFormat %s
section baseline
no_agent (380.751 µs) : 361, 401
. : milestone, 381,
iast (491.591 µs) : 470, 513
. : milestone, 492,
iast_FULL (662.172 µs) : 640, 684
. : milestone, 662,
iast_GLOBAL (524.209 µs) : 503, 546
. : milestone, 524,
iast_HARDCODED_SECRET_DISABLED (502.84 µs) : 482, 524
. : milestone, 503,
iast_INACTIVE (461.657 µs) : 441, 483
. : milestone, 462,
iast_TELEMETRY_OFF (484.971 µs) : 464, 506
. : milestone, 485,
tracing (463.511 µs) : 441, 486
. : milestone, 464,
section candidate
no_agent (381.307 µs) : 362, 401
. : milestone, 381,
iast (500.085 µs) : 478, 522
. : milestone, 500,
iast_FULL (658.818 µs) : 637, 680
. : milestone, 659,
iast_GLOBAL (525.484 µs) : 504, 547
. : milestone, 525,
iast_HARDCODED_SECRET_DISABLED (494.65 µs) : 473, 516
. : milestone, 495,
iast_INACTIVE (465.555 µs) : 444, 487
. : milestone, 466,
iast_TELEMETRY_OFF (488.647 µs) : 467, 510
. : milestone, 489,
tracing (456.436 µs) : 435, 478
. : milestone, 456,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~dac2889c6e, baseline=1.45.0-SNAPSHOT~a3e9bda406
dateFormat X
axisFormat %s
section baseline
no_agent (1.463 ms) : 1452, 1474
. : milestone, 1463,
appsec (2.341 ms) : 2299, 2382
. : milestone, 2341,
iast (2.088 ms) : 2034, 2141
. : milestone, 2088,
iast_GLOBAL (2.136 ms) : 2082, 2190
. : milestone, 2136,
profiling (1.997 ms) : 1950, 2043
. : milestone, 1997,
tracing (1.934 ms) : 1893, 1975
. : milestone, 1934,
section candidate
no_agent (1.466 ms) : 1455, 1477
. : milestone, 1466,
appsec (2.344 ms) : 2302, 2386
. : milestone, 2344,
iast (2.089 ms) : 2036, 2142
. : milestone, 2089,
iast_GLOBAL (2.126 ms) : 2073, 2179
. : milestone, 2126,
profiling (1.95 ms) : 1908, 1993
. : milestone, 1950,
tracing (1.932 ms) : 1891, 1972
. : milestone, 1932,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~dac2889c6e, baseline=1.45.0-SNAPSHOT~a3e9bda406
dateFormat X
axisFormat %s
section baseline
no_agent (14.694 s) : 14694000, 14694000
. : milestone, 14694000,
appsec (14.953 s) : 14953000, 14953000
. : milestone, 14953000,
iast (18.684 s) : 18684000, 18684000
. : milestone, 18684000,
iast_GLOBAL (17.839 s) : 17839000, 17839000
. : milestone, 17839000,
profiling (15.849 s) : 15849000, 15849000
. : milestone, 15849000,
tracing (15.012 s) : 15012000, 15012000
. : milestone, 15012000,
section candidate
no_agent (15.226 s) : 15226000, 15226000
. : milestone, 15226000,
appsec (15.056 s) : 15056000, 15056000
. : milestone, 15056000,
iast (18.908 s) : 18908000, 18908000
. : milestone, 18908000,
iast_GLOBAL (18.019 s) : 18019000, 18019000
. : milestone, 18019000,
profiling (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
tracing (15.152 s) : 15152000, 15152000
. : milestone, 15152000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: testing
Testing
run-tests: all
Run all tests
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Follow up to #8111.
Various errors can appear more frequently than I anticipated. They need to be excluded.
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]