-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Check logs for errors at smoke tests cleanup (#8111)" #8125
Open
smola
wants to merge
1
commit into
master
Choose a base branch
from
smola/revert-check-error-logs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ab205f6.
smola
added
comp: testing
Testing
tag: no release notes
Changes to exclude from release notes
run-tests: all
Run all tests
labels
Dec 20, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~8c7b630ed0, baseline=1.45.0-SNAPSHOT~a3e9bda406
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052318
Total [baseline] (10.494 s) : 0, 10494419
Agent [candidate] (1.06 s) : 0, 1059670
Total [candidate] (10.398 s) : 0, 10397720
section appsec
Agent [baseline] (1.187 s) : 0, 1186654
Total [baseline] (10.749 s) : 0, 10749304
Agent [candidate] (1.189 s) : 0, 1188929
Total [candidate] (10.721 s) : 0, 10720530
section iast
Agent [baseline] (1.179 s) : 0, 1179056
Total [baseline] (10.98 s) : 0, 10979931
Agent [candidate] (1.175 s) : 0, 1174951
Total [candidate] (10.957 s) : 0, 10957060
section profiling
Agent [baseline] (1.275 s) : 0, 1275137
Total [baseline] (10.862 s) : 0, 10862013
Agent [candidate] (1.297 s) : 0, 1296893
Total [candidate] (10.967 s) : 0, 10967468
gantt
title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~8c7b630ed0, baseline=1.45.0-SNAPSHOT~a3e9bda406
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (710.477 ms) : 0, 710477
BytebuddyAgent [candidate] (715.769 ms) : 0, 715769
GlobalTracer [baseline] (255.797 ms) : 0, 255797
GlobalTracer [candidate] (257.287 ms) : 0, 257287
AppSec [baseline] (57.983 ms) : 0, 57983
AppSec [candidate] (58.115 ms) : 0, 58115
Remote Config [baseline] (697.24 µs) : 0, 697
Remote Config [candidate] (701.733 µs) : 0, 702
Telemetry [baseline] (12.474 ms) : 0, 12474
Telemetry [candidate] (12.641 ms) : 0, 12641
section appsec
BytebuddyAgent [baseline] (729.219 ms) : 0, 729219
BytebuddyAgent [candidate] (730.389 ms) : 0, 730389
GlobalTracer [baseline] (253.127 ms) : 0, 253127
GlobalTracer [candidate] (253.186 ms) : 0, 253186
AppSec [baseline] (171.123 ms) : 0, 171123
AppSec [candidate] (171.833 ms) : 0, 171833
Remote Config [baseline] (660.677 µs) : 0, 661
Remote Config [candidate] (668.87 µs) : 0, 669
Telemetry [baseline] (7.995 ms) : 0, 7995
Telemetry [candidate] (8.062 ms) : 0, 8062
IAST [baseline] (19.202 ms) : 0, 19202
IAST [candidate] (19.712 ms) : 0, 19712
section iast
BytebuddyAgent [baseline] (829.389 ms) : 0, 829389
BytebuddyAgent [candidate] (826.314 ms) : 0, 826314
GlobalTracer [baseline] (246.868 ms) : 0, 246868
GlobalTracer [candidate] (245.561 ms) : 0, 245561
AppSec [baseline] (57.811 ms) : 0, 57811
AppSec [candidate] (57.945 ms) : 0, 57945
Remote Config [baseline] (667.584 µs) : 0, 668
Remote Config [candidate] (655.129 µs) : 0, 655
Telemetry [baseline] (8.487 ms) : 0, 8487
Telemetry [candidate] (8.427 ms) : 0, 8427
IAST [baseline] (20.975 ms) : 0, 20975
IAST [candidate] (21.14 ms) : 0, 21140
section profiling
ProfilingAgent [baseline] (95.606 ms) : 0, 95606
ProfilingAgent [candidate] (99.19 ms) : 0, 99190
BytebuddyAgent [baseline] (702.591 ms) : 0, 702591
BytebuddyAgent [candidate] (711.571 ms) : 0, 711571
GlobalTracer [baseline] (372.271 ms) : 0, 372271
GlobalTracer [candidate] (379.725 ms) : 0, 379725
AppSec [baseline] (54.067 ms) : 0, 54067
AppSec [candidate] (55.266 ms) : 0, 55266
Remote Config [baseline] (661.28 µs) : 0, 661
Remote Config [candidate] (702.125 µs) : 0, 702
Telemetry [baseline] (7.948 ms) : 0, 7948
Telemetry [candidate] (8.031 ms) : 0, 8031
Profiling [baseline] (95.63 ms) : 0, 95630
Profiling [candidate] (99.216 ms) : 0, 99216
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~8c7b630ed0, baseline=1.45.0-SNAPSHOT~a3e9bda406
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049206
Total [baseline] (8.63 s) : 0, 8630493
Agent [candidate] (1.059 s) : 0, 1059038
Total [candidate] (8.674 s) : 0, 8674243
section iast
Agent [baseline] (1.175 s) : 0, 1175358
Total [baseline] (9.255 s) : 0, 9254540
Agent [candidate] (1.18 s) : 0, 1180062
Total [candidate] (9.252 s) : 0, 9252320
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.177 s) : 0, 1177217
Total [baseline] (9.19 s) : 0, 9189939
Agent [candidate] (1.192 s) : 0, 1191564
Total [candidate] (9.242 s) : 0, 9241772
section iast_TELEMETRY_OFF
Agent [baseline] (1.18 s) : 0, 1179574
Total [baseline] (9.23 s) : 0, 9229562
Agent [candidate] (1.173 s) : 0, 1173174
Total [candidate] (9.179 s) : 0, 9178896
gantt
title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~8c7b630ed0, baseline=1.45.0-SNAPSHOT~a3e9bda406
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (710.748 ms) : 0, 710748
BytebuddyAgent [candidate] (715.847 ms) : 0, 715847
GlobalTracer [baseline] (255.273 ms) : 0, 255273
GlobalTracer [candidate] (256.938 ms) : 0, 256938
AppSec [baseline] (57.847 ms) : 0, 57847
AppSec [candidate] (57.657 ms) : 0, 57657
Remote Config [baseline] (692.164 µs) : 0, 692
Remote Config [candidate] (698.707 µs) : 0, 699
Telemetry [baseline] (9.772 ms) : 0, 9772
Telemetry [candidate] (12.821 ms) : 0, 12821
section iast
BytebuddyAgent [baseline] (827.3 ms) : 0, 827300
BytebuddyAgent [candidate] (828.798 ms) : 0, 828798
GlobalTracer [baseline] (245.533 ms) : 0, 245533
GlobalTracer [candidate] (248.138 ms) : 0, 248138
AppSec [baseline] (57.426 ms) : 0, 57426
AppSec [candidate] (57.776 ms) : 0, 57776
IAST [baseline] (21.079 ms) : 0, 21079
IAST [candidate] (21.248 ms) : 0, 21248
Remote Config [baseline] (662.306 µs) : 0, 662
Remote Config [candidate] (684.249 µs) : 0, 684
Telemetry [baseline] (8.475 ms) : 0, 8475
Telemetry [candidate] (8.539 ms) : 0, 8539
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (827.505 ms) : 0, 827505
BytebuddyAgent [candidate] (838.699 ms) : 0, 838699
GlobalTracer [baseline] (246.543 ms) : 0, 246543
GlobalTracer [candidate] (248.833 ms) : 0, 248833
AppSec [baseline] (57.823 ms) : 0, 57823
AppSec [candidate] (58.215 ms) : 0, 58215
IAST [baseline] (21.257 ms) : 0, 21257
IAST [candidate] (21.513 ms) : 0, 21513
Remote Config [baseline] (662.342 µs) : 0, 662
Remote Config [candidate] (665.574 µs) : 0, 666
Telemetry [baseline] (8.507 ms) : 0, 8507
Telemetry [candidate] (8.552 ms) : 0, 8552
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (829.309 ms) : 0, 829309
BytebuddyAgent [candidate] (824.573 ms) : 0, 824573
GlobalTracer [baseline] (247.487 ms) : 0, 247487
GlobalTracer [candidate] (246.282 ms) : 0, 246282
AppSec [baseline] (57.789 ms) : 0, 57789
AppSec [candidate] (57.677 ms) : 0, 57677
IAST [baseline] (20.986 ms) : 0, 20986
IAST [candidate] (20.734 ms) : 0, 20734
Remote Config [baseline] (659.091 µs) : 0, 659
Remote Config [candidate] (653.543 µs) : 0, 654
Telemetry [baseline] (8.374 ms) : 0, 8374
Telemetry [candidate] (8.334 ms) : 0, 8334
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~8c7b630ed0, baseline=1.45.0-SNAPSHOT~a3e9bda406
dateFormat X
axisFormat %s
section baseline
no_agent (1.353 ms) : 1332, 1374
. : milestone, 1353,
appsec (1.762 ms) : 1737, 1788
. : milestone, 1762,
appsec_no_iast (1.786 ms) : 1761, 1810
. : milestone, 1786,
iast (1.489 ms) : 1466, 1512
. : milestone, 1489,
profiling (1.528 ms) : 1505, 1552
. : milestone, 1528,
tracing (1.499 ms) : 1475, 1523
. : milestone, 1499,
section candidate
no_agent (1.341 ms) : 1322, 1361
. : milestone, 1341,
appsec (1.75 ms) : 1727, 1774
. : milestone, 1750,
appsec_no_iast (1.749 ms) : 1723, 1774
. : milestone, 1749,
iast (1.502 ms) : 1478, 1525
. : milestone, 1502,
profiling (1.535 ms) : 1511, 1559
. : milestone, 1535,
tracing (1.506 ms) : 1480, 1531
. : milestone, 1506,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~8c7b630ed0, baseline=1.45.0-SNAPSHOT~a3e9bda406
dateFormat X
axisFormat %s
section baseline
no_agent (380.902 µs) : 361, 400
. : milestone, 381,
iast (492.915 µs) : 471, 515
. : milestone, 493,
iast_FULL (656.226 µs) : 634, 678
. : milestone, 656,
iast_GLOBAL (520.716 µs) : 499, 542
. : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (494.24 µs) : 473, 516
. : milestone, 494,
iast_INACTIVE (458.142 µs) : 436, 480
. : milestone, 458,
iast_TELEMETRY_OFF (482.373 µs) : 461, 504
. : milestone, 482,
tracing (458.624 µs) : 438, 480
. : milestone, 459,
section candidate
no_agent (373.069 µs) : 353, 393
. : milestone, 373,
iast (501.746 µs) : 479, 525
. : milestone, 502,
iast_FULL (660.811 µs) : 639, 682
. : milestone, 661,
iast_GLOBAL (525.889 µs) : 504, 547
. : milestone, 526,
iast_HARDCODED_SECRET_DISABLED (498.058 µs) : 477, 520
. : milestone, 498,
iast_INACTIVE (453.483 µs) : 432, 475
. : milestone, 453,
iast_TELEMETRY_OFF (486.25 µs) : 465, 508
. : milestone, 486,
tracing (460.07 µs) : 439, 481
. : milestone, 460,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~8c7b630ed0, baseline=1.45.0-SNAPSHOT~a3e9bda406
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.365 ms) : 2324, 2407
. : milestone, 2365,
iast (2.112 ms) : 2059, 2165
. : milestone, 2112,
iast_GLOBAL (2.141 ms) : 2088, 2195
. : milestone, 2141,
profiling (1.965 ms) : 1923, 2007
. : milestone, 1965,
tracing (1.937 ms) : 1896, 1977
. : milestone, 1937,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (2.365 ms) : 2323, 2406
. : milestone, 2365,
iast (2.099 ms) : 2046, 2152
. : milestone, 2099,
iast_GLOBAL (2.138 ms) : 2085, 2191
. : milestone, 2138,
profiling (1.961 ms) : 1919, 2003
. : milestone, 1961,
tracing (1.947 ms) : 1906, 1987
. : milestone, 1947,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~8c7b630ed0, baseline=1.45.0-SNAPSHOT~a3e9bda406
dateFormat X
axisFormat %s
section baseline
no_agent (15.279 s) : 15279000, 15279000
. : milestone, 15279000,
appsec (14.83 s) : 14830000, 14830000
. : milestone, 14830000,
iast (18.874 s) : 18874000, 18874000
. : milestone, 18874000,
iast_GLOBAL (17.951 s) : 17951000, 17951000
. : milestone, 17951000,
profiling (15.041 s) : 15041000, 15041000
. : milestone, 15041000,
tracing (14.867 s) : 14867000, 14867000
. : milestone, 14867000,
section candidate
no_agent (14.911 s) : 14911000, 14911000
. : milestone, 14911000,
appsec (15.162 s) : 15162000, 15162000
. : milestone, 15162000,
iast (18.68 s) : 18680000, 18680000
. : milestone, 18680000,
iast_GLOBAL (18.156 s) : 18156000, 18156000
. : milestone, 18156000,
profiling (15.443 s) : 15443000, 15443000
. : milestone, 15443000,
tracing (15.281 s) : 15281000, 15281000
. : milestone, 15281000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: testing
Testing
run-tests: all
Run all tests
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This reverts commit ab205f6.
Motivation
This led to an increase of failures in master, in particular for variants that we do not run in PRs such as IBM8.
I will bring back this PR together with tweaks from #8123
but at the moment, I'll revert to keep master more stable.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]