-
Notifications
You must be signed in to change notification settings - Fork 493
feat(contrib/mcp-go): Simplified way to add tracing #4122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
| // The file contains methods for easily adding tracing to a MCP server. | ||
|
|
||
| type TracingConfig struct { | ||
| Hooks *server.Hooks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future (next PR in stack) a boolean option to enable intent capture will be added to this config.
BenchmarksBenchmark execution time: 2025-11-20 20:04:12 Comparing candidate commit 1c7172d in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 0 unstable metrics. |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 1c7172d | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
9f5e898 to
9ae69b2
Compare
335ba2a to
0237e37
Compare
9ae69b2 to
b214025
Compare
0237e37 to
6bacb1a
Compare
b214025 to
58df1a2
Compare
58df1a2 to
bb9ade0
Compare
genesor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add an example and in documentation of how customer should use it with pre-existing hooks. Otherwise LGTM
e8cc9ba to
625180d
Compare
|
View all feedbacks in Devflow UI.
|
625180d to
ae93ce3
Compare
ae93ce3 to
1c7172d
Compare
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|

What does this PR do?
Provides a simpler, more extensible, and less leaky way to add tracing to
mcp-go.Motivation
Previously I proposed a version which used reflection, but changed approaches: #4115
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!