feat(contrib/go-sdk): Initial `go-sdk` tracer implementation #4199

jboolean · 2025-12-02T14:44:40Z

What does this PR do?

Implements tracing of modelcontextprotocol/go-sdk with the same functionality as mark3labs/mcp-go.

Motivation

Closes https://datadoghq.atlassian.net/browse/MLOB-4639

Reviewer's Checklist

Changed code has unit tests for its functionality at or near 100% coverage.
System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
There is a benchmark for any new code, or changes to existing code.
If this interacts with the agent in a new way, a system test has been added.
New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
Add an appropriate team label so this PR gets put in the right place for the release notes.
Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

jboolean · 2025-12-02T14:45:03Z

feat(contrib/go-sdk): Add intent capture to go-sdk #4209
feat(contrib/go-sdk): Initial go-sdk tracer implementation #4199 👈 (View in Graphite)
feat(contrib/mcp-go): Intent capture #4123
feat(contrib/mcp-go): Simplified way to add tracing #4122 : 1 other dependent PR (#4158 )
feat(contrib/mcp-go): Trace MCP session initializations with MLObs spans #4101 : 2 other dependent PRs (#4106 , #4115 )
feat(contrib/mcp-go): Initial mcp-go tracer implementation #4100
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

datadog-datadog-prod-us1 · 2025-12-02T14:50:59Z

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: a1b1e1a | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

pr-commenter · 2025-12-02T14:51:57Z

Benchmarks

Benchmark execution time: 2025-12-04 20:07:05

Comparing candidate commit a1b1e1a in PR branch jb/tracing-for-go-sdk with baseline commit 5682bdb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

instrumentation/packages.go

contrib/modelcontextprotocol/go-sdk/go.mod

contrib/modelcontextprotocol/go-sdk/testing.go

contrib/modelcontextprotocol/go-sdk/tracing.go

rarguelloF

LGTM, left a comment about a potential improvement on the llmobs SDK (which can be done/discussed in a future PR)

rarguelloF · 2025-12-04T08:52:20Z

contrib/modelcontextprotocol/go-sdk/tracing.go

+type textIOSpan interface {
+	AnnotateTextIO(input, output string, opts ...llmobs.AnnotateOption)
+	Finish(opts ...llmobs.FinishSpanOption)
+}


if this kind of code is gonna be common when using our llmobs sdk, it might be worth it to include something in the core llmobs package itself to make life easier for all users.

Maybe AnnotateTextIO should be available in all span types, including AnySpan, WDYT?

It would be nice if llmobs just exported the textIOSpan interface it already has (llmobs.go:389)

Oops, that's not an interface.
I didn't see an elegant way to publish a nice, reusable interface that's widely useful. Played with it for a bit.

We could add it to all span types but it looks like llm spans don't support it and use messages instead and I don't want methods that are not applicable.

I'm not going to go further down this rabbit hole for now.

codecov · 2025-12-04T16:32:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.13%. Comparing base (21d8bbb) to head (a1b1e1a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Files with missing lines	Coverage Δ
instrumentation/packages.go	`9.23% <ø> (ø)`
internal/stacktrace/contribs_generated.go	`100.00% <100.00%> (ø)`

... and 76 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dd-devflow-routing-codex · 2025-12-04T19:02:37Z

View all feedbacks in Devflow UI.

2025-12-04 19:02:37 UTC ℹ️ Start processing command devflow:merge

2025-12-04 19:02:42 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 45m (p90).

2025-12-04 19:03:02 UTC ❌ MergeQueue: This merge request has conflicts

This merge request conflicts with another merge request ahead in the queue.

The merge requests in front of this one are:

#4205 with merge sha 4bcaa16

dd-devflow-routing-codex · 2025-12-04T19:26:14Z

View all feedbacks in Devflow UI.

2025-12-04 19:26:14 UTC ℹ️ Start processing command devflow:merge

2025-12-04 19:26:25 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-12-04 20:10:19 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 45m (p90).

2025-12-04 20:54:40 UTC ℹ️ MergeQueue: This merge request was merged

jboolean mentioned this pull request Dec 2, 2025

feat(contrib/mcp-go): Intent capture #4123

Merged

7 tasks

github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Dec 2, 2025

jboolean changed the title ~~Tracing for go-sdk~~ feat(contrib/go-sdk): Tracing for go-sdk Dec 2, 2025

jboolean changed the title ~~feat(contrib/go-sdk): Tracing for go-sdk~~ feat(contrib/go-sdk): Initial go-sdk tracer implementation Dec 2, 2025

jboolean force-pushed the jb/tracing-for-go-sdk branch 5 times, most recently from d680e25 to e62619f Compare December 2, 2025 15:34

jboolean commented Dec 2, 2025

View reviewed changes

instrumentation/packages.go Outdated Show resolved Hide resolved

jboolean commented Dec 2, 2025

View reviewed changes

instrumentation/packages.go Show resolved Hide resolved

jboolean force-pushed the jb/tracing-for-go-sdk branch from e62619f to 79e412f Compare December 2, 2025 18:10

jboolean requested a review from hannahkm December 2, 2025 18:32

jboolean marked this pull request as ready for review December 2, 2025 18:34

jboolean requested review from a team as code owners December 2, 2025 18:34

darccio requested changes Dec 3, 2025

View reviewed changes

contrib/modelcontextprotocol/go-sdk/go.mod Outdated Show resolved Hide resolved

genesor reviewed Dec 3, 2025

View reviewed changes

contrib/modelcontextprotocol/go-sdk/testing.go Outdated Show resolved Hide resolved

contrib/modelcontextprotocol/go-sdk/tracing.go Outdated Show resolved Hide resolved

jboolean force-pushed the jb/contrib-mcp-go-intent-capture branch from 4285bb9 to f99dd20 Compare December 3, 2025 19:19

jboolean force-pushed the jb/tracing-for-go-sdk branch from d58bedd to 299d5b6 Compare December 3, 2025 19:19

jboolean mentioned this pull request Dec 3, 2025

feat(contrib/go-sdk): Add intent capture to go-sdk #4209

Merged

7 tasks

jboolean requested a review from darccio December 3, 2025 19:24

rarguelloF approved these changes Dec 4, 2025

View reviewed changes

darccio approved these changes Dec 4, 2025

View reviewed changes

jboolean requested a review from genesor December 4, 2025 15:58

Base automatically changed from jb/contrib-mcp-go-intent-capture to main December 4, 2025 16:15

dd-mergequeue bot requested a review from a team as a code owner December 4, 2025 16:15

jboolean force-pushed the jb/tracing-for-go-sdk branch from 299d5b6 to b30dc5b Compare December 4, 2025 16:26

genesor approved these changes Dec 4, 2025

View reviewed changes

jboolean added the devflow:merge label Dec 4, 2025 — with Graphite App

dd-devflow bot added mergequeue-status: queued mergequeue-status: in_progress mergequeue-status: rejected and removed mergequeue-status: queued mergequeue-status: in_progress labels Dec 4, 2025

Tracing for go-sdk

a1b1e1a

jboolean force-pushed the jb/tracing-for-go-sdk branch from b30dc5b to a1b1e1a Compare December 4, 2025 19:23

jboolean removed the devflow:merge label Dec 4, 2025

jboolean added the devflow:merge label Dec 4, 2025 — with Graphite App

dd-devflow bot added mergequeue-status: waiting mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: rejected mergequeue-status: waiting mergequeue-status: queued labels Dec 4, 2025

dd-mergequeue bot merged commit 2dc2312 into main Dec 4, 2025
271 checks passed

dd-devflow bot added mergequeue-status: done and removed mergequeue-status: in_progress labels Dec 4, 2025

dd-mergequeue bot deleted the jb/tracing-for-go-sdk branch December 4, 2025 20:54

feat(contrib/go-sdk): Initial go-sdk tracer implementation #4199

feat(contrib/go-sdk): Initial go-sdk tracer implementation #4199

Conversation

jboolean commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Reviewer's Checklist

Uh oh!

jboolean commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datadog-datadog-prod-us1 bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rarguelloF left a comment

Choose a reason for hiding this comment

Uh oh!

rarguelloF Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

jboolean Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

jboolean Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dd-devflow-routing-codex bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dd-devflow-routing-codex bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat(contrib/go-sdk): Initial `go-sdk` tracer implementation #4199

feat(contrib/go-sdk): Initial `go-sdk` tracer implementation #4199

jboolean commented Dec 2, 2025 •

edited

Loading

jboolean commented Dec 2, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Dec 2, 2025 •

edited

Loading

pr-commenter bot commented Dec 2, 2025 •

edited

Loading

codecov bot commented Dec 4, 2025 •

edited

Loading

dd-devflow-routing-codex bot commented Dec 4, 2025 •

edited

Loading

dd-devflow-routing-codex bot commented Dec 4, 2025 •

edited

Loading