Skip to content

configs/config.protectli_vp66xx: enable me #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wiktormowinski wants to merge 3 commits into
base: dasharo
Choose a base branch
from
Open

configs/config.protectli_vp66xx: enable me #802

wiktormowinski wants to merge 3 commits into from

Conversation

@wiktormowinski
Copy link
Contributor

@wiktormowinski wiktormowinski commented Oct 29, 2025

No description provided.

@macpijan
Copy link
Contributor

macpijan commented Oct 29, 2025

@wiktormowinski Please follow: https://docs.dasharo.com/dev-proc/source-code-structure/#commit-quality when contributing to coreboot/edk2 repositories.

macpijan
macpijan reviewed Oct 29, 2025
View reviewed changes
src/mainboard/protectli/vault_adl_p/devicetree.cb

register "tcc_offset" = "20" # TCC of 80C

register "usb2_wake_enable_bitmap" = "0x0002"
Copy link
Contributor

@macpijan macpijan Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be in the enable ME commit?

@wiktormowinski wiktormowinski force-pushed the vp66xx-parity branch 2 times, most recently from cf7b40c to caaa6f4 Compare December 9, 2025 17:33
@wiktormowinski
src/mainboard/protectli/vault_adl_p/devicetree.cb: add usb wake
0ff520e 
Upstream-Status: Inappropriate [Dasharo downstream]
Signed-off-by: Wiktor Mowinski <[email protected]>
@wiktormowinski
configs/config.protectli_vp66xx: enable ME
ac616a8 
Upstream-Status: Inappropriate [Dasharo downstream]
Signed-off-by: Wiktor Mowinski <[email protected]>
@wiktormowinski wiktormowinski force-pushed the vp66xx-parity branch 3 times, most recently from fc88f77 to 1f0d07c Compare December 10, 2025 09:40
@wiktormowinski
Copy link
Contributor Author

wiktormowinski commented Dec 10, 2025 •
edited
Loading

@mkopec i need your help. This approach is being constantly marked as syntax error by runner.
1f0d07c
is this even a correct way to enable wol?

@mkopec
Copy link
Member

mkopec commented Dec 10, 2025

@wiktormowinski doesn't look correct. Try doing what this patch does: https://review.coreboot.org/c/coreboot/+/89783

mkopec
mkopec reviewed Dec 10, 2025
View reviewed changes
src/mainboard/protectli/vault_adl_p/devicetree.cb Outdated
device ref pcie_rp8 on
register "pch_pcie_rp[PCH_RP(8)]" = "{
.flags = PCIE_RP_LTR | PCIE_RP_AER | PCIE_RP_CLK_REQ_UNUSED,
.flags = PCIE_RP_LTR | PCIE_RP_AER | PCIE_RP_CLK_REQ_UNUSED | PCIE_RP_PM_ENABLE,
Copy link
Member

@mkopec mkopec Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this flag? Doesn't seeem to exist

Copy link
Contributor Author

@wiktormowinski wiktormowinski Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at first i tried every option i could find, including this pm fleg enabling nonsense

mkopec
mkopec reviewed Dec 10, 2025
View reviewed changes
src/mainboard/protectli/vault_adl_p/devicetree.cb Outdated
Comment on lines 245 to 246
end
end
Copy link
Member

@mkopec mkopec Dec 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many ends? also please fix indentation

Copy link
Contributor Author

@wiktormowinski wiktormowinski Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mb, device domain 0 on is being ended right here

Copy link
Contributor Author

@wiktormowinski wiktormowinski Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that explains failed runs (they pointed to some random line so i was confused)

@wiktormowinski wiktormowinski force-pushed the vp66xx-parity branch 2 times, most recently from 10c84e0 to 5ba4106 Compare December 10, 2025 10:48
@wiktormowinski
src/mainboard/protectli/vault_adl_p/devicetree.cb: enable wake on eth
06eaf2c 
Upstream-Status: Inappropriate [Dasharo downstream]
Signed-off-by: Wiktor Mowinski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkopec mkopec mkopec left review comments

@macpijan macpijan macpijan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wiktormowinski @macpijan @mkopec