Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge main #88

Merged
merged 8 commits into from
Oct 11, 2024
Merged

merge main #88

merged 8 commits into from
Oct 11, 2024

Conversation

sindhu-ku
Copy link
Member

No description provided.

Copy link
Collaborator

@chenel chenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine apart from one header deletion I'm unsure about

#include "reco/SANDRecoBranchFiller.h"
#include "reco/MINERvARecoBranchFiller.h"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably stay. Unsure why it was deleted?

@sindhu-ku
Copy link
Member Author

sindhu-ku commented Oct 5, 2024

Sorry, this wasn't meant for you. I need to fix conflicts to merge changes from main (track matching) to the IFbeam branch, so I haven't merged it yet. That was git's auto merge.

@chenel
Copy link
Collaborator

chenel commented Oct 5, 2024

ah, I didn't notice that this one runs the other way (it's merging from main rather than into main), sorry.

FYI, this PR doesn't contain anything about IFBeam, so I haven't looked at that yet (still unburying myself from messages)

@sindhu-ku sindhu-ku merged commit e137b1d into pot_info Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants