-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/local user login #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
reviewed
Jul 8, 2023
moontai0724
requested changes
Jul 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments above
e058f3b
to
701a7ef
Compare
701a7ef
to
8f55f55
Compare
57fa5d2
to
f9dd2ea
Compare
moontai0724
reviewed
Aug 23, 2023
moontai0724
requested changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect! some small advices
89270a0
to
30c6d21
Compare
69431ab
to
a3f71c3
Compare
6c7423c
to
ee6b2d1
Compare
moontai0724
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things
1. Setup Local Passport and unit test.
use for user login, username/password authentication mechanism.
Install
@nestjs/passport
,passport
,passport-local
JwtUser:{email, id}
2. Setup JWT Passport and unit test.
use for user Verify identity.
Install
@nestjs/jwt
,passport-jwt
,@types/passport-jwt
JwtUser:{email, id}
3. Local user login and unit test.
local user login, when valid sucess will return
access token
andrefresh token
4. Add a script to test one file.
"test:one": "jest --testPathPattern",
5. Add Swagger documentation for local login and refresh token API.