refactor: delete if clause based on suggestions

Cophr · Aug 31, 2023 · 69431ab · 69431ab
1 parent 1cff4b6
commit 69431ab
Showing 1 changed file with 12 additions and 23 deletions.
diff --git a/src/auth/local/local-auth.guard.spec.ts b/src/auth/local/local-auth.guard.spec.ts
@@ -1,8 +1,4 @@
-import {
-  type ExecutionContext,
-  ForbiddenException,
-  HttpException,
-} from "@nestjs/common";
+import { type ExecutionContext, ForbiddenException } from "@nestjs/common";
 import { BadRequestException } from "@nestjs/common/exceptions";
 import { PassportModule } from "@nestjs/passport";
 import { Test } from "@nestjs/testing";
@@ -90,13 +86,11 @@ describe("LocalAuthGuard", () => {
     try {
       await localAuthGuard.canActivate(mockExecutionContext);
     } catch (error) {
-      if (error instanceof HttpException) {
-        expect(error).toBeInstanceOf(ForbiddenException);
-        expect(error.getResponse()).toEqual({
-          message: ["Account or password is wrong."],
-          statusCode: 403,
-        });
-      }
+      expect(error).toBeInstanceOf(ForbiddenException);
+      expect((error as BadRequestException).getResponse()).toEqual({
+        message: ["Account or password is wrong."],
+        statusCode: 403,
+      });
     }
   });
 
@@ -116,17 +110,12 @@ describe("LocalAuthGuard", () => {
     try {
       await localAuthGuard.canActivate(mockExecutionContext);
     } catch (error) {
-      if (error instanceof HttpException) {
-        expect(error).toBeInstanceOf(BadRequestException);
-        expect(error.getResponse()).toEqual({
-          error: "Bad Request",
-          message: [
-            "password 必須長度大於等於8個字。",
-            "password 為必填欄位。",
-          ],
-          statusCode: 400,
-        });
-      }
+      expect(error).toBeInstanceOf(BadRequestException);
+      expect((error as BadRequestException).getResponse()).toEqual({
+        error: "Bad Request",
+        message: ["password 必須長度大於等於8個字。", "password 為必填欄位。"],
+        statusCode: 400,
+      });
     }
   });
 });