refactor: optimize the code according to the suggestions

Cophr · Aug 31, 2023 · 1cff4b6 · 1cff4b6
1 parent 7f8912e
commit 1cff4b6
Showing 1 changed file with 17 additions and 34 deletions.
diff --git a/src/auth/auth.controller.spec.ts b/src/auth/auth.controller.spec.ts
@@ -95,17 +95,19 @@ describe("AuthController", () => {
           });
         });
     });
+  });
 
-    it("should return access, refresh token and 201 http code when account information is correct.", async () => {
-      const request: Request = {
-        user: {
-          id: 1,
-        } as JwtUser,
-      } as unknown as Request;
-
-      const fakeAccessToken = "mocked_access_token";
-      const fakeRefreshToken = "mocked_refresh_token";
-
+  describe("login and refresh", () => {
+    const request: Request = {
+      user: {
+        id: 1,
+      } as JwtUser,
+    } as unknown as Request;
+    const fakeAccessToken = "mocked_access_token";
+    const fakeRefreshToken = "mocked_refresh_token";
+    let mockedAuthService: jest.SpyInstance;
+
+    beforeEach(async () => {
       jest
         .spyOn(authService, "generateAccessToken")
         .mockReturnValue(Promise.resolve(fakeAccessToken));
@@ -114,12 +116,13 @@ describe("AuthController", () => {
         .spyOn(authService, "generateRefreshToken")
         .mockReturnValue(Promise.resolve(fakeRefreshToken));
 
-      const mockAuthService = jest.spyOn(authService, "sign");
+      mockedAuthService = jest.spyOn(authService, "sign");
+    });
 
+    it("should return access, refresh token and 201 http code when account information is correct.", async () => {
       const result = await authController.login(request);
 
-      expect(mockAuthService).toHaveBeenCalledWith(request.user);
-
+      expect(mockedAuthService).toHaveBeenCalledWith(request.user);
       const expectedResponse: GenerateTokenResponse = {
         accessToken: fakeAccessToken,
         refreshToken: fakeRefreshToken,
@@ -130,29 +133,9 @@ describe("AuthController", () => {
     });
 
     it("should return access, refresh token and 201 http code when refresh token is correct.", async () => {
-      const request: Request = {
-        user: {
-          id: 1,
-        } as JwtUser,
-      } as unknown as Request;
-
-      const fakeAccessToken = "mocked_access_token";
-      const fakeRefreshToken = "mocked_refresh_token";
-
-      jest
-        .spyOn(authService, "generateAccessToken")
-        .mockReturnValue(Promise.resolve(fakeAccessToken));
-
-      jest
-        .spyOn(authService, "generateRefreshToken")
-        .mockReturnValue(Promise.resolve(fakeRefreshToken));
-
-      const mockAuthService = jest.spyOn(authService, "sign");
-
       const result = await authController.refresh(request);
 
-      expect(mockAuthService).toHaveBeenCalledWith(request.user);
-
+      expect(mockedAuthService).toHaveBeenCalledWith(request.user);
       const expectedResponse: GenerateTokenResponse = {
         accessToken: fakeAccessToken,
         refreshToken: fakeRefreshToken,