Skip to content

Code review cleanup #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Liam310 merged 2 commits into from
Jun 11, 2026
Merged

Code review cleanup #1910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24de376
remove references to dead code review channel
Liam310 Jun 11, 2026
1edf189
update guide for locating first PR
Liam310 Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion org-cyf-guides/content/reviewing/code-review-basics/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,6 @@ If you want to dive deeper into code review, check out these resources:

## Practice Exercise

Find an open pull request in the [#cyf-code-review](https://codeyourfutur-yov6609.slack.com/archives/C07QX99JK7B) channel and practice reviewing it using this guide.
Find an open pull request by joining the [#cyf-code-review-volunteer-team](https://codeyourfutur-yov6609.slack.com/archives/C0A1E83EZRP) channel and following one of the links in the **Code Review Resources** tab. Once you've chosen one, practice reviewing it using this guide.

Remember: Code review is a conversation, not a judgment. We're all learning!
2 changes: 1 addition & 1 deletion org-cyf/content/itp/data-flows/success/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,6 @@ weight = 11
1. Submit the issue link to step 4 of ITP on [CYF Course Portal](https://application-process.codeyourfuture.io/).

> [!NOTE]
> A pull request is _completed_ when a volunteer has added the "Complete" tag. If nobody has reviewed your PR after one week, please ask on Slack in #cyf-code-review.
> A pull request is _completed_ when a volunteer has added the "Complete" tag.

Celebrate your hard work by checking off the objectives below!
2 changes: 1 addition & 1 deletion org-cyf/content/itp/data-groups/success/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@ weight = 11
1. Submit the issue link to step 3 of ITP on [CYF Course Portal](https://application-process.codeyourfuture.io/).

> [!NOTE]
> A pull request is _completed_ when a volunteer has added the "Complete" tag. If nobody has reviewed your PR after one week, please ask on Slack in #cyf-code-review.
> A pull request is _completed_ when a volunteer has added the "Complete" tag.

Celebrate your hard work by checking off the objectives below!
2 changes: 1 addition & 1 deletion org-cyf/content/itp/onboarding/success/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ weight = 11
1. **[Apply to enroll as a Trainee](https://forms.gle/vRuofa7aeL5DsbhGA)**.

> [!NOTE]
> A pull request is _completed_ when a volunteer has added the "Complete" tag. If nobody has reviewed your PR after one week, please ask on Slack in #cyf-code-review.
> A pull request is _completed_ when a volunteer has added the "Complete" tag.

Celebrate your hard work by checking off the objectives below!
2 changes: 1 addition & 1 deletion org-cyf/content/itp/structuring-data/success/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,6 @@ weight = 11
1. Submit the issue link to step 2 of ITP on [CYF Course Portal](https://application-process.codeyourfuture.io/).

> [!NOTE]
> A pull request is _completed_ when a volunteer has added the "Complete" tag. If nobody has reviewed your PR after one week, please ask on Slack in #cyf-code-review.
> A pull request is _completed_ when a volunteer has added the "Complete" tag.

Celebrate your hard work by checking off the objectives below!
Loading