Skip to content

Code review cleanup#1910

Merged
Liam310 merged 2 commits into
mainfrom
code_review_cleanup
Jun 11, 2026
Merged

Code review cleanup#1910
Liam310 merged 2 commits into
mainfrom
code_review_cleanup

Conversation

@Liam310

@Liam310 Liam310 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Upon closing the #cyf-code-review channel we are also removing the stipulation that trainees should notify us when their work hasn't been reviewed for a week, given that we have the capacity currently to basically always avoid this being an issue.

This PR:

  • Removes the references to the one-week expectation for reviewing PRs
  • Updates reference to #cyf-code-review to instead by #cyf-code-review-volunteer-team when inviting prospective new code reviewers

@netlify

netlify Bot commented Jun 11, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-curriculum ready!

Name Link
🔨 Latest commit 1edf189
🔍 Latest deploy log https://app.netlify.com/projects/cyf-curriculum/deploys/6a2aa041a8c7950008da2246
😎 Deploy Preview https://deploy-preview-1910--cyf-curriculum.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 87 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 11, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-common ready!

Name Link
🔨 Latest commit 1edf189
🔍 Latest deploy log https://app.netlify.com/projects/cyf-common/deploys/6a2aa041f7d8fe0008054e4d
😎 Deploy Preview https://deploy-preview-1910--cyf-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-project-automation github-project-automation Bot moved this from 📋 Backlog to 👀 In review in Curriculum Planning Jun 11, 2026
@Liam310 Liam310 merged commit 0bc6396 into main Jun 11, 2026
11 checks passed
@Liam310 Liam310 deleted the code_review_cleanup branch June 11, 2026 13:06
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in Curriculum Planning Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants