generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 42
ZA | 25-SDC-Nov | Rashaad Ebrahim | Sprint 4 | Implement cowsay (Python) #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Rashaad-Ebrahim
wants to merge
9
commits into
CodeYourFuture:main
Choose a base branch
from
Rashaad-Ebrahim:implement-cowsay
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5be1c78
gitignore updated
Rashaad-Ebrahim 3895c1c
cow.py file added and project setup with requirements.txt
Rashaad-Ebrahim 8671d12
argparse setup for project
Rashaad-Ebrahim 62bd86e
Basic logic complete
Rashaad-Ebrahim 7d1e4b7
cowsay implementation complete, code cleaned up
Rashaad-Ebrahim bd4f33e
Code added into main function as per Python best practice
Rashaad-Ebrahim 7125d1a
If statement removed and default value added to animal flag
Rashaad-Ebrahim b3b1526
gitignore updated
Rashaad-Ebrahim b808b06
requirements.txt added
Rashaad-Ebrahim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| node_modules | ||
| **/.venv | ||
| **/requirements.txt | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import cowsay | ||
| import argparse | ||
|
|
||
| def main(): | ||
| # Get dynamic list of animals from the cowsay library | ||
| animals = cowsay.char_names | ||
|
|
||
| parser = argparse.ArgumentParser( | ||
| prog="cowsay", | ||
| description="Make animals say things" | ||
| ) | ||
|
|
||
| parser.add_argument("--animal", choices=animals, default="cow",help="The animal to be saying things.") | ||
| parser.add_argument("message", nargs="+", help="The message to say.") | ||
|
|
||
| args = parser.parse_args() | ||
|
|
||
| # Join all message words into a single string | ||
| message = " ".join(args.message) | ||
|
|
||
| # Output the message using the selected animal or the default cow | ||
| cowsay.char_funcs[args.animal](message) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| main() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't ignore the requirements file, it is important for the PR so people pulling know what library to install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted!
Code has been updated