-
-
Notifications
You must be signed in to change notification settings - Fork 42
ZA | 25-SDC-Nov | Rashaad Ebrahim | Sprint 4 | Implement cowsay (Python) #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ZA | 25-SDC-Nov | Rashaad Ebrahim | Sprint 4 | Implement cowsay (Python) #279
Conversation
LonMcGregor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good solution, one small change suggested for the PR
.gitignore
Outdated
| @@ -1 +1,3 @@ | |||
| node_modules | |||
| **/.venv | |||
| **/requirements.txt | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't ignore the requirements file, it is important for the PR so people pulling know what library to install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted!
Code has been updated
|
great work on this. |
Learners, PR Template
Self checklist
Changelist
My cowsay implementations.
Questions
No questions at this time