Skip to content

Conversation

@Rashaad-Ebrahim
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

My cowsay implementations.

Questions

No questions at this time

@Rashaad-Ebrahim Rashaad-Ebrahim added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 4, 2025
@Rashaad-Ebrahim Rashaad-Ebrahim changed the title ZA | 25-SDC-Nov | Rashaad Ebrahim | Sprint 4 | Implement cowsay ZA | 25-SDC-Nov | Rashaad Ebrahim | Sprint 4 | Implement cowsay (Python) Dec 4, 2025
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Dec 23, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution, one small change suggested for the PR

.gitignore Outdated
@@ -1 +1,3 @@
node_modules
**/.venv
**/requirements.txt

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't ignore the requirements file, it is important for the PR so people pulling know what library to install

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted!

Code has been updated

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Dec 23, 2025
@Rashaad-Ebrahim Rashaad-Ebrahim added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 23, 2025
@LonMcGregor
Copy link

great work on this.

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

02 Implement cowsay in Python

2 participants