Fortitude v0.7 #310
Merged
Fortitude v0.7 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwallwork23
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
* Ignoring of `C003` 'implicit none' missing 'external' as this is a f2013 feature and we want to support back to f2008.
That's fine.
* Adding an explicit `public` statement to the ftorch and test utils modules. * This is correct for the test utils, but I think we should have a discussion about whether everything in the ftorch module should be public.
I agree this is the right thing to do for now to maintain the current API. But yes, we should discuss whether some of the procedures should be made private in a future meeting.
|
Thanks @jwallwork23 opened #311 to capture this for a future discussion and will merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to use the latest version of the Fortran fortitude linter which included a few API changes
Notably it adds:
C003'implicit none' missing 'external' as this is a f2013 feature and we want to support back to f2008.publicstatement to the ftorch and test utils modules.