Fortitude v0.7 (#310)

* Update ignored fortitude fules after breaking changes and add C003.

* Explicitly label ftorch and test_utils as a fully public module.

* Update pFUnit files to satisfy Fortitude.

* Bump fortitude to version 0.7 in requirements.txt file.

* Update workflow to remove file-specific rules.

Author: jatkinson1000

.github/workflows/static_analysis.yml

@@ -99,7 +99,7 @@ jobs:
         run: |
           cd ${{ github.workspace }}
           . ftorch_venv/bin/activate
-          fortitude check --ignore=E001,T041 src/ftorch.F90
+          fortitude check src/ftorch.F90
           fortitude check src/ftorch_test_utils.f90
 
       # Apply C++ and C linter and formatter, clang

fortitude.toml

@@ -1,4 +1,5 @@
 [check]
 # Ignored Rules and justification:
-#   T041: assumed size - we require assumed size for library functionality when passing data to C/C++
-ignore = ["T041"]
+#   C003: 'implicit none' missing 'external' - this is a Fortran 2013 feature and we support older standards
+#   C071: assumed size - we require assumed size for library functionality when passing data to C/C++
+ignore = ["C003", "C071"]

requirements.txt

@@ -1,5 +1,5 @@
 ruff==0.7.3
-fortitude-lint==0.6.0
+fortitude-lint==0.7.0
 clang-format==19.1.3
 clang-tidy==19.1.0
 cmakelang

src/ftorch.F90

@@ -13,6 +13,8 @@ module ftorch
 
   implicit none
 
+  public
+
   ! Set integer size for FTorch library
   integer, parameter :: ftorch_int = int32
 

src/ftorch.fypp

@@ -32,6 +32,8 @@ module ftorch
 
   implicit none
 
+  public
+
   ! Set integer size for FTorch library
   integer, parameter :: ftorch_int = int32
 

src/ftorch_test_utils.f90

@@ -11,6 +11,8 @@ module ftorch_test_utils
 
   implicit none
 
+  public
+
   interface assert_isclose
     module procedure assert_isclose_real32
     module procedure assert_isclose_real64

src/ftorch_test_utils.fypp

@@ -19,6 +19,8 @@ module ftorch_test_utils
 
   implicit none
 
+  public
+
   interface assert_isclose
     #:for PREC in PRECISIONS
     module procedure assert_isclose_${PREC}$

test/unit/test_tensor_constructors_destructors.pf

@@ -39,7 +39,7 @@ contains
   ! Constructor for the test case type
   function test_case_ctor(param)
     type(TestCaseType) :: test_case_ctor
-    type(TestParametersType) :: param
+    type(TestParametersType), intent(in) :: param
     test_case_ctor%param = param
   end function test_case_ctor
 
@@ -396,7 +396,7 @@ contains
     ! assignment operator
     tensor2 = tensor1
 
-    ! Compare the data in the tensor to the input data 
+    ! Compare the data in the tensor to the input data
     test_pass = assert_allclose(out_data, in_data, test_name="test_torch_tensor_from_blob")
 
     if (.not. test_pass) then

test/unit/test_tensor_interrogation.pf

@@ -22,8 +22,6 @@ contains
   @test
   subroutine test_torch_tensor_get_rank_1D()
 
-    implicit none
-
     type(torch_tensor) :: tensor
     integer, parameter :: ndims = 1
     integer(kind=c_int64_t), parameter :: tensor_shape(ndims) = [6]
@@ -40,8 +38,6 @@ contains
   @test
   subroutine test_torch_tensor_get_rank_2D()
 
-    implicit none
-
     type(torch_tensor) :: tensor
     integer, parameter :: ndims = 2
     integer(kind=c_int64_t), parameter :: tensor_shape(ndims) = [2,3]
@@ -58,8 +54,6 @@ contains
   @test
   subroutine test_torch_tensor_get_rank_3D()
 
-    implicit none
-
     type(torch_tensor) :: tensor
     integer, parameter :: ndims = 3
     integer(kind=c_int64_t), parameter :: tensor_shape(ndims) = [1,2,3]
@@ -76,8 +70,6 @@ contains
   @test
   subroutine test_torch_tensor_get_shape_1D()
 
-    implicit none
-
     type(torch_tensor) :: tensor
     integer, parameter :: ndims = 1
     integer(kind=c_int64_t), parameter :: tensor_shape(ndims) = [6]
@@ -94,8 +86,6 @@ contains
   @test
   subroutine test_torch_tensor_get_shape_2D()
 
-    implicit none
-
     type(torch_tensor) :: tensor
     integer, parameter :: ndims = 2
     integer(kind=c_int64_t), parameter :: tensor_shape(ndims) = [2, 3]
@@ -112,8 +102,6 @@ contains
   @test
   subroutine test_torch_tensor_get_shape_3D()
 
-    implicit none
-
     type(torch_tensor) :: tensor
     integer, parameter :: ndims = 3
     integer(kind=c_int64_t), parameter :: tensor_shape(ndims) = [1, 2, 3]
@@ -130,8 +118,6 @@ contains
   @test
   subroutine test_torch_tensor_get_dtype()
 
-    implicit none
-
     type(torch_tensor) :: tensor
     integer, parameter :: ndims = 1
     integer(c_int64_t), parameter, dimension(ndims) :: tensor_shape = [1]
@@ -149,8 +135,6 @@ contains
   @test
   subroutine test_torch_tensor_get_device_type()
 
-    implicit none
-
     type(torch_tensor) :: tensor
     integer, parameter :: ndims = 1
     integer(c_int64_t), parameter, dimension(ndims) :: tensor_shape = [1]
@@ -168,8 +152,6 @@ contains
   @test
   subroutine test_torch_tensor_get_device_index_default()
 
-    implicit none
-
     type(torch_tensor) :: tensor
     integer, parameter :: ndims = 1
     integer(c_int64_t), parameter, dimension(ndims) :: tensor_shape = [1]

test/unit/test_tensor_operator_overloads.pf

@@ -50,7 +50,7 @@ contains
   ! Constructor for the test case type
   function test_case_ctor(param)
     type(TestCaseType) :: test_case_ctor
-    type(TestParametersType) :: param
+    type(TestParametersType), intent(in) :: param
     test_case_ctor%param = param
   end function test_case_ctor
 
@@ -67,8 +67,6 @@ contains
   subroutine test_torch_tensor_assign(this)
     use, intrinsic :: iso_fortran_env, only: sp => real32
 
-    implicit none
-
     ! Set working precision for reals
     integer, parameter :: wp = sp
 
@@ -116,8 +114,6 @@ contains
     use ftorch, only: operator(+)
     use, intrinsic :: iso_fortran_env, only: sp => real32
 
-    implicit none
-
     ! Set working precision for reals
     integer, parameter :: wp = sp
 
@@ -172,8 +168,6 @@ contains
     use ftorch, only: operator(-)
     use, intrinsic :: iso_fortran_env, only: sp => real32
 
-    implicit none
-
     ! Set working precision for reals
     integer, parameter :: wp = sp
 
@@ -233,8 +227,6 @@ contains
     use, intrinsic :: iso_fortran_env, only: sp => real32
     use, intrinsic :: iso_c_binding, only : c_associated, c_int64_t
 
-    implicit none
-
     ! Set working precision for reals
     integer, parameter :: wp = sp
 
@@ -338,8 +330,6 @@ contains
     use ftorch, only: operator(*)
     use, intrinsic :: iso_fortran_env, only: sp => real32
 
-    implicit none
-
     ! Set working precision for reals
     integer, parameter :: wp = sp
 
@@ -394,8 +384,6 @@ contains
     use ftorch, only: operator(/)
     use, intrinsic :: iso_fortran_env, only: sp => real32
 
-    implicit none
-
     ! Set working precision for reals
     integer, parameter :: wp = sp
 
@@ -450,8 +438,6 @@ contains
     use ftorch, only: operator(/)
     use, intrinsic :: iso_fortran_env, only: sp => real32
 
-    implicit none
-
     ! Set working precision for reals
     integer, parameter :: wp = sp
 
@@ -502,8 +488,6 @@ contains
     use ftorch, only: operator(**)
     use, intrinsic :: iso_fortran_env, only: sp => real32
 
-    implicit none
-
     ! Set working precision for reals
     integer, parameter :: wp = sp
 
@@ -557,8 +541,6 @@ contains
     use, intrinsic :: iso_fortran_env, only: sp => real32
     use, intrinsic :: iso_c_binding, only : c_associated, c_int64_t
 
-    implicit none
-
     ! Set working precision for reals
     integer, parameter :: wp = sp