Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Find messages received with Unicast Flag set to 0 (multicast) shall be ignored #762

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

SarbeenaS
Copy link
Contributor

Fix for Find messages received with Unicast Flag set to 0 (multicast) shall be answered with a multicast response

…, shall be answered with a multicast response
@duartenfonseca
Copy link
Collaborator

duartenfonseca commented Oct 21, 2024

Hi @SarbeenaS , if you check: https://www.autosar.org/fileadmin/standards/R20-11/FO/AUTOSAR_PRS_SOMEIPServiceDiscoveryProtocol.pdf
the requirement(PRS_SOMEIPSD_00423) mentions this:

Find messages received with Unicast Flag set to 0 (multicast), shall be ignored

which is not the change you requested, but is also not the way vsomeip is working right now

@duartenfonseca
Copy link
Collaborator

@SarbeenaS could you review the changes requested?

@duartenfonseca duartenfonseca changed the title Fix for Find messages received with Unicast Flag set to 0 (multicast) shall be answered with a multicast response Fix for Find messages received with Unicast Flag set to 0 (multicast) shall be ignored Jan 7, 2025
@duartenfonseca duartenfonseca merged commit 555b980 into COVESA:master Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants