Fix for Find messages received with Unicast Flag set to 0 (multicast)…

… shall be ignored (#762) Fix for Find messages received with Unicast Flag set to 0 (multicast) shall be ignored --------- Co-authored-by: Duarte Fonseca <[email protected]>
COVESA · Jan 7, 2025 · 555b980 · 555b980
1 parent 1f55ff9
commit 555b980
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/implementation/service_discovery/src/service_discovery_impl.cpp b/implementation/service_discovery/src/service_discovery_impl.cpp
@@ -1693,7 +1693,9 @@ service_discovery_impl::send_unicast_offer_service(
 
     insert_offer_service(its_messages, _info);
 
-    serialize_and_send(its_messages, current_remote_address_);
+    // send message as multicast offer service the same way it is sent
+    // on the repetition phase to preserve the session id
+    send(its_messages);
 }
 
 void
@@ -1705,7 +1707,7 @@ service_discovery_impl::send_multicast_offer_service(
 
     insert_offer_service(its_messages, _info);
 
-    serialize_and_send(its_messages, current_remote_address_);
+    serialize_and_send(its_messages, sd_multicast_address_);
 }
 
 void
@@ -3309,8 +3311,9 @@ service_discovery_impl::send_uni_or_multicast_offerservice(
         } else { // SIP_SD_90
             send_multicast_offer_service(_info);
         }
-    } else { // SID_SD_826
-        send_unicast_offer_service(_info);
+    } else {
+        // SIP_SD_91
+        // Find messages received with Unicast Flag set to 0 (multicast), shall be ignored        
     }
 }