Skip to content

Remove criterion exclude attribute, use logical criterion combination with not instead #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glichtner merged 9 commits into from
Dec 10, 2024

tests: remove insert_criterion exclude tests

78a0237
Select commit
Loading
Failed to load commit list.
Merged

Remove criterion exclude attribute, use logical criterion combination with not instead #242

tests: remove insert_criterion exclude tests
78a0237
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/patch succeeded Dec 10, 2024 in 0s

88.88% of diff hit (target 87.65%)

View this Pull Request on Codecov

88.88% of diff hit (target 87.65%)

Annotations

Check warning on line 134 in execution_engine/omop/criterion/abstract.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

execution_engine/omop/criterion/abstract.py#L134 

Added line #L134 was not covered by tests

Check warning on line 156 in execution_engine/omop/criterion/combination/combination.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

execution_engine/omop/criterion/combination/combination.py#L156 

Added line #L156 was not covered by tests

Check warning on line 160 in execution_engine/omop/criterion/combination/combination.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

execution_engine/omop/criterion/combination/combination.py#L160 

Added line #L160 was not covered by tests

Check warning on line 164 in execution_engine/omop/criterion/combination/combination.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

execution_engine/omop/criterion/combination/combination.py#L164 

Added line #L164 was not covered by tests

Check warning on line 166 in execution_engine/omop/criterion/combination/combination.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

execution_engine/omop/criterion/combination/combination.py#L166 

Added line #L166 was not covered by tests

Check warning on line 171 in execution_engine/omop/criterion/combination/combination.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

execution_engine/omop/criterion/combination/combination.py#L171 

Added line #L171 was not covered by tests
View more details on Codecov