Remove criterion exclude attribute, use logical criterion combination with not instead #242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the
_excludeattribute in criteria classes led to inconsistent mapping between criterion objects and logic expression objects as well a few complications which arose from handling this mismatch.This major change in pull request is separated into two commits
Introduce the logical criterion combinations with operator not and use it where appropriate.
As a result of this change, the
_excludeattribute is alwaysFalse.Remove the
_excludeand logic for validating and inverting it.Both commits represent consistent states in which all tests should pass.