Skip to content

Fix failing test for CMake 4 #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanmrichard merged 5 commits into from
Jun 24, 2025
Merged

Fix failing test for CMake 4 #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3251947
Add CMake minimum version command matching minimum version of CMaize
Jun 24, 2025
cf13de1
Remove old 'cpp/' test directory reference and use relative paths for…
Jun 24, 2025
074fc49
Default to using VERBOSE log level in tests
Jun 24, 2025
d05b637
Fix line numbers referencing bare_bones_cmake from the docs
Jun 24, 2025
1623f63
Revert minimum version of bare_bones_cmake example back to 3.5 to mat…
Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/background/redundancy.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ then the minimal ``CMakeLists.txt`` file looks like:

.. literalinclude:: /../../tests/docs/bare_bones_cmake/CMakeLists.txt
:language: CMake
:lines: 15
:lines: 18-20
:linenos:
:lineno-start: 1

Expand Down
8 changes: 6 additions & 2 deletions tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ include(cmake_test/cmake_test)

set(BUILD_TESTING "${build_testing_old}" CACHE BOOL "" FORCE)

# ct_add_dir("cpp")
ct_add_dir("cmaize")
ct_add_dir(
"cmaize"
USE_REL_PATH_NAMES
CMAKE_OPTIONS
-DCMAKE_MESSAGE_LOG_LEVEL=VERBOSE
)
add_subdirectory(docs)
5 changes: 5 additions & 0 deletions tests/docs/bare_bones_cmake/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# Minimum version required as of CMake 4.0
# (see https://cmake.org/cmake/help/latest/policy/CMP0000.html).
# Match this with minimum version from 'CMaize/CMakeLists.txt'.
cmake_minimum_required(VERSION 3.5) # Required as of CMake 4.0

add_executable(hello_world hello_world.cpp)

# The below lines of code are used in unit testing this code example
Expand Down