Fix failing test for CMake 4 #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 23, 2025 19:03
…ch other examples
ryanmrichard
approved these changes
Jun 24, 2025
|
🚀 [bumpr] Bumped! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
Fixes #168.
Description
Updates the
tests/docs/bare_bones_cmaketest to include a minimum CMake version, since it is required since CMake 4. Also updates the documentation referencing this code to ensure it uses the correct lines.I also performed a bit of testing cleanup/updates that have been sitting in my local repo for a while.
CMAKE_MESSAGE_LOG_LEVELtoVERBOSEfor testing. The reasoning is that you will only see the text when a test is failing, and when a test is failing, you will want verbose information about what happened to determine why it is failing.