Skip to content

Conversation

@SamuelBrand1
Copy link
Collaborator

@SamuelBrand1 SamuelBrand1 commented Dec 17, 2025

This is another pass at #790 with full CI triggered.

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 39.62264% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.71%. Comparing base (9be7dba) to head (336051d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hewr/R/process_loc_forecast.R 39.62% 64 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #795      +/-   ##
==========================================
+ Coverage   39.43%   41.71%   +2.27%     
==========================================
  Files          30       30              
  Lines        2713     2817     +104     
==========================================
+ Hits         1070     1175     +105     
+ Misses       1643     1642       -1     
Flag Coverage Δ
hewr 37.97% <39.62%> (+8.03%) ⬆️
pipelines 35.87% <ø> (ø)
pyrenew_hew 62.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

SamuelBrand1 and others added 14 commits December 17, 2025 22:14
Updates `process_loc_forecast` to delegate to the new interface when `model_name` is provided, and adds comprehensive tests for model type detection, S3 dispatch, and interface validation.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This reverts commit 8b5cfd4.
@SamuelBrand1
Copy link
Collaborator Author

SamuelBrand1 commented Dec 17, 2025

The fix to the problem is here

processed_forecast <- process_loc_forecast(
model_run_dir = model_run_dir,
n_forecast_days = n_forecast_days,
pyrenew_model_name = pyrenew_model_name,
timeseries_model_name = timeseries_model_name,
save = TRUE
)

The change to hewr meant that this needed to be changed to kwarg rather than positional args

@SamuelBrand1 SamuelBrand1 marked this pull request as ready for review December 17, 2025 22:20
@SamuelBrand1 SamuelBrand1 changed the title Draft: trigger CI to debug DO NOT MERGE Fix to #790 Dec 17, 2025
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SamuelBrand1!

@SamuelBrand1 SamuelBrand1 merged commit 115c9ef into main Dec 17, 2025
70 checks passed
@SamuelBrand1 SamuelBrand1 deleted the 788-inflexible-logic branch December 17, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants