-
Notifications
You must be signed in to change notification settings - Fork 3
Fix to #790 #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to #790 #795
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #795 +/- ##
==========================================
+ Coverage 39.43% 41.71% +2.27%
==========================================
Files 30 30
Lines 2713 2817 +104
==========================================
+ Hits 1070 1175 +105
+ Misses 1643 1642 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d1bd42b to
8b5cfd4
Compare
Updates `process_loc_forecast` to delegate to the new interface when `model_name` is provided, and adds comprehensive tests for model type detection, S3 dispatch, and interface validation.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This reverts commit 8b5cfd4.
71c2bac to
336051d
Compare
|
The fix to the problem is here pyrenew-hew/pipelines/plot_and_save_loc_forecast.R Lines 67 to 73 in 336051d
The change to |
damonbayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SamuelBrand1!
This is another pass at #790 with full CI triggered.