Skip to content

Conversation

@SamuelBrand1
Copy link
Collaborator

This pull request changes the model selection logic for location forecast processing by introducing model_name parameter with auto-detection of model type. This is aimed at using the S3 method approach introduced in #790 #795 .

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.82%. Comparing base (668ebeb) to head (34fab85).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pipelines/common_utils.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #804      +/-   ##
==========================================
- Coverage   41.85%   41.82%   -0.03%     
==========================================
  Files          30       30              
  Lines        2807     2809       +2     
==========================================
  Hits         1175     1175              
- Misses       1632     1634       +2     
Flag Coverage Δ
hewr 37.97% <100.00%> (ø)
pipelines 36.09% <0.00%> (-0.06%) ⬇️
pyrenew_hew 62.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit. Thanks @SamuelBrand1!

@SamuelBrand1 SamuelBrand1 merged commit 7a861c5 into main Dec 22, 2025
70 checks passed
@SamuelBrand1 SamuelBrand1 deleted the add-generic-model-name-postprocess branch December 22, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants