Skip to content

Name a cut-off <input> in its edit tooltip #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christophsax wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Name a cut-off <input> in its edit tooltip #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion inst/assets/js/blockr-ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,9 @@ Blockr.tooltip = (() => {
// The attribute can go again (a name editable only in a mode).
if (!el.hasAttribute('data-blockr-editable')) return null;
const hint = el.getAttribute('data-blockr-editable') || HINT;
return Blockr.cutOff(el) ? { name: (el.textContent || '').trim(), label: hint } : hint;
// An <input> holds its text in `value`, not in its content.
const text = el instanceof HTMLInputElement ? el.value : el.textContent;
return Blockr.cutOff(el) ? { name: (text || '').trim(), label: hint } : hint;
});
};

Expand Down
13 changes: 13 additions & 0 deletions tests/js/tooltip.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,19 @@ test('editable text names its gesture, the default or its own', (newWindow) => {
win.close();
});

test('a cut-off editable <input> names its value', (newWindow) => {
const win = newWindow();
const input = win.document.createElement('input');
input.value = 'Patients with a serious adverse event';
input.setAttribute('data-blockr-editable', '');
win.document.body.append(input);
Object.defineProperty(input, 'clientWidth', { value: 80 });
Object.defineProperty(input, 'scrollWidth', { value: 240 });
over(win, input);
assert.match(win.Blockr.tooltip.text(input), /Patients with a serious adverse event/);
win.close();
});

test('a native title that reaches the page is left to its owner', (newWindow) => {
// Blockr markup carries data-blockr-tooltip instead. Rewriting other
// code's titles froze them (a title cleared later kept its old card) and
Expand Down
Loading