Name a cut-off <input> in its edit tooltip - #75
Open
christophsax wants to merge 1 commit into
Open
christophsax wants to merge 1 commit into
christophsax wants to merge 1 commit into
Conversation
An editable input holds its text in value, so the tooltip for a cut-off name showed only the gesture.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An editable
<input>(a block name being renamed in place) holds its text invalue, not in its content. When the name was cut off, the edit tooltip readtextContent, got nothing, and showed only the gesture. It now readsvaluefor an input.Test added in
tooltip.test.js; it fails without the fix.