Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Task Scheduler Queue Task called when SychronizationContext disposed #3451

Merged
merged 4 commits into from
Dec 31, 2024
Merged

fix: Task Scheduler Queue Task called when SychronizationContext disposed #3451

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8330d4c
fix: add immediate execution back
iancooper Dec 31, 2024
617f505
fix: use a new thread if the context has closed
iancooper Dec 31, 2024
1c63673
fix: missing code, should have been in last commit
iancooper Dec 31, 2024
95d6970
Merge branch 'master' into sync_await_false_fix
iancooper Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions src/Paramore.Brighter/Tasks/BrighterTaskScheduler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Threading;
using System.Threading.Tasks;

namespace Paramore.Brighter.Tasks;
Expand Down Expand Up @@ -60,13 +61,14 @@ protected override void QueueTask(Task task)

var queued = _synchronizationHelper.Enqueue((Task)task, false);
if (!queued)
{
{
Debug.IndentLevel = 1;
Debug.WriteLine($"BrighterTaskScheduler: QueueTask Failed to queue task {task.ToString()} on {System.Threading.Thread.CurrentThread.ManagedThreadId}");
Debug.IndentLevel = 0;
new Thread(TryExecuteNewThread) { IsBackground = true }.Start(task);
}
}

/// <summary>
/// Attempts to execute the specified task on the current thread.
/// </summary>
Expand Down Expand Up @@ -103,4 +105,28 @@ public void DoTryExecuteTask(Task task)

TryExecuteTask(task);
}

/// <summary>
/// In a new thread, attempts to execute the specified task.
/// </summary>
/// <remarks>
/// This is a little "Hail Mary" to try and execute a task that has failed to queue because we have already completed the synchronization context.
/// Seems to be caused by an Exection Context that has our scheduler as the default, as it fools ConfigureAwait
/// </remarks>
/// <param name="obj"></param>
/// <exception cref="ArgumentNullException"></exception>
private void TryExecuteNewThread(object? obj)
{
var task = obj as Task;
if (task == null)
{
throw new ArgumentNullException(nameof(obj));
}

Debug.IndentLevel = 1;
Debug.WriteLine($"BrighterTaskScheduler: Use TryExecuteNewThread for {task} on thread {System.Threading.Thread.CurrentThread.ManagedThreadId}");
Debug.IndentLevel = 0;

TryExecuteTask(task);
}
}
Loading