fix: Task Scheduler Queue Task called when SychronizationContext disposed #3451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iancooper
requested review from
holytshirt,
DevJonny and
preardon
as code owners
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our synchronization context, when we complete adding tasks, we pump the pending continuations in the queue.
We expect to then restore the old synchronization context
In some cases, we get an issue where we are then handed another continuation via the scheduler. The blockingcollection is complete, and even it it was not, nothing will pump the continuations.
(We can reproduce thanks to @rafael Andrade by using a Task.Delay())
In this case, we just use a "Hail Mary" approach (cribbed from RavenDb) of putting the queued task on a new thread.