Skip to content

ci: pass inputs via env: instead of templating into run blocks #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rubydusa wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ci: pass inputs via env: instead of templating into run blocks #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions .github/workflows/_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,10 @@ jobs:

- name: Install dependencies
if: inputs.package-manager != 'none'
env:
PACKAGE_MANAGER: ${{ inputs.package-manager }}
run: |
case "${{ inputs.package-manager }}" in
case "$PACKAGE_MANAGER" in
npm) npm ci ;;
yarn) yarn --frozen-lockfile ;;
pnpm) corepack enable && pnpm install --frozen-lockfile ;;
Expand All @@ -108,7 +110,8 @@ jobs:
- name: Run tests
env:
RPC_URL: ${{ secrets.RPC_URL }}
run: forge test -${{ inputs.test-verbosity }}
TEST_VERBOSITY: ${{ inputs.test-verbosity }}
run: forge test "-$TEST_VERBOSITY"

slither:
name: Slither Analysis
Expand All @@ -132,8 +135,10 @@ jobs:

- name: Install dependencies
if: inputs.package-manager != 'none'
env:
PACKAGE_MANAGER: ${{ inputs.package-manager }}
run: |
case "${{ inputs.package-manager }}" in
case "$PACKAGE_MANAGER" in
npm) npm ci ;;
yarn) yarn --frozen-lockfile ;;
pnpm) corepack enable && pnpm install --frozen-lockfile ;;
Expand Down Expand Up @@ -179,8 +184,10 @@ jobs:

- name: Install dependencies
if: inputs.package-manager != 'none'
env:
PACKAGE_MANAGER: ${{ inputs.package-manager }}
run: |
case "${{ inputs.package-manager }}" in
case "$PACKAGE_MANAGER" in
npm) npm ci ;;
yarn) yarn --frozen-lockfile ;;
pnpm) corepack enable && pnpm install --frozen-lockfile ;;
Expand All @@ -192,9 +199,10 @@ jobs:
- name: Run coverage
env:
RPC_URL: ${{ secrets.RPC_URL }}
COVERAGE_EXCLUDE_PATHS: ${{ inputs.coverage-exclude-paths }}
run: |
if [[ -n "${{ inputs.coverage-exclude-paths }}" ]]; then
forge coverage --no-match-path "${{ inputs.coverage-exclude-paths }}" 2>&1 | tee coverage-raw.txt
if [[ -n "$COVERAGE_EXCLUDE_PATHS" ]]; then
forge coverage --no-match-path "$COVERAGE_EXCLUDE_PATHS" 2>&1 | tee coverage-raw.txt
else
forge coverage 2>&1 | tee coverage-raw.txt
fi
Expand Down Expand Up @@ -243,8 +251,10 @@ jobs:

- name: Install dependencies
if: inputs.package-manager != 'none'
env:
PACKAGE_MANAGER: ${{ inputs.package-manager }}
run: |
case "${{ inputs.package-manager }}" in
case "$PACKAGE_MANAGER" in
npm) npm ci ;;
yarn) yarn --frozen-lockfile ;;
pnpm) corepack enable && pnpm install --frozen-lockfile ;;
Expand Down
22 changes: 15 additions & 7 deletions .github/workflows/_deploy-testnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,36 +80,44 @@ jobs:

- name: Install dependencies
if: inputs.package-manager != 'none'
env:
PACKAGE_MANAGER: ${{ inputs.package-manager }}
run: |
case "${{ inputs.package-manager }}" in
case "$PACKAGE_MANAGER" in
npm) npm ci ;;
yarn) yarn --frozen-lockfile ;;
pnpm) corepack enable && pnpm install --frozen-lockfile ;;
esac

- name: Read network config
id: network
env:
NETWORK_INDEX: ${{ inputs.network-index }}
NETWORK_CONFIG_PATH: ${{ inputs.network-config-path }}
run: |
BLOCKSCOUT_URL=$(jq -r '.testnets[${{ inputs.network-index }}].blockscout_url' ${{ inputs.network-config-path }})
NETWORK_NAME=$(jq -r '.testnets[${{ inputs.network-index }}].name' ${{ inputs.network-config-path }})
echo "blockscout_url=$BLOCKSCOUT_URL" >> $GITHUB_OUTPUT
echo "network_name=$NETWORK_NAME" >> $GITHUB_OUTPUT
BLOCKSCOUT_URL=$(jq -r ".testnets[$NETWORK_INDEX].blockscout_url" "$NETWORK_CONFIG_PATH")
NETWORK_NAME=$(jq -r ".testnets[$NETWORK_INDEX].name" "$NETWORK_CONFIG_PATH")
echo "blockscout_url=$BLOCKSCOUT_URL" >> "$GITHUB_OUTPUT"
echo "network_name=$NETWORK_NAME" >> "$GITHUB_OUTPUT"

- name: Deploy contracts
env:
PRIVATE_KEY: ${{ secrets.PRIVATE_KEY }}
RPC_URL: ${{ secrets.RPC_URL }}
DEPLOY_ENV_VARS: ${{ secrets.DEPLOY_ENV_VARS }}
DEPLOY_SCRIPT: ${{ inputs.deploy-script }}
run: |
source .etherform/scripts/deploy/prepare-env.sh
forge script ${{ inputs.deploy-script }} \
forge script "$DEPLOY_SCRIPT" \
--rpc-url "$RPC_URL" \
--broadcast \
--slow \
-vvvv

- name: Wait for indexing
run: sleep ${{ inputs.indexing-wait }}
env:
INDEXING_WAIT: ${{ inputs.indexing-wait }}
run: sleep "$INDEXING_WAIT"

- name: Parse deployment addresses
id: parse
Expand Down
66 changes: 45 additions & 21 deletions .github/workflows/_foundry-cicd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,13 +146,17 @@ jobs:

- name: Build paths filter
id: paths
env:
CONTRACT_PATHS: ${{ inputs.contract-paths }}
run: |
# Convert newline-separated paths to YAML list format
YAML_PATHS=$(echo "${{ inputs.contract-paths }}" | sed '/^$/d' | sed 's/^/ - /')
echo "filter<<EOF" >> $GITHUB_OUTPUT
echo "contracts:" >> $GITHUB_OUTPUT
echo "$YAML_PATHS" >> $GITHUB_OUTPUT
echo "EOF" >> $GITHUB_OUTPUT
YAML_PATHS=$(echo "$CONTRACT_PATHS" | sed '/^$/d' | sed 's/^/ - /')
{
echo "filter<<EOF"
echo "contracts:"
echo "$YAML_PATHS"
echo "EOF"
} >> "$GITHUB_OUTPUT"

- name: Check for contract changes
id: filter
Expand All @@ -162,16 +166,19 @@ jobs:

- name: Decide whether to run
id: decide
env:
SKIP_IF_NO_CHANGES: ${{ inputs.skip-if-no-changes }}
CONTRACTS_CHANGED: ${{ steps.filter.outputs.contracts }}
run: |
if [[ "${{ inputs.skip-if-no-changes }}" == "false" ]]; then
if [[ "$SKIP_IF_NO_CHANGES" == "false" ]]; then
echo "Change detection disabled, workflow will run"
echo "should-run=true" >> $GITHUB_OUTPUT
elif [[ "${{ steps.filter.outputs.contracts }}" == "true" ]]; then
echo "should-run=true" >> "$GITHUB_OUTPUT"
elif [[ "$CONTRACTS_CHANGED" == "true" ]]; then
echo "Contract changes detected, workflow will run"
echo "should-run=true" >> $GITHUB_OUTPUT
echo "should-run=true" >> "$GITHUB_OUTPUT"
else
echo "No contract changes detected, skipping workflow"
echo "should-run=false" >> $GITHUB_OUTPUT
echo "should-run=false" >> "$GITHUB_OUTPUT"
fi

ci:
Expand All @@ -197,8 +204,10 @@ jobs:

- name: Install dependencies
if: inputs.package-manager != 'none'
env:
PACKAGE_MANAGER: ${{ inputs.package-manager }}
run: |
case "${{ inputs.package-manager }}" in
case "$PACKAGE_MANAGER" in
npm) npm ci ;;
yarn) yarn --frozen-lockfile ;;
pnpm) corepack enable && pnpm install --frozen-lockfile ;;
Expand All @@ -217,7 +226,8 @@ jobs:
- name: Run tests
env:
RPC_URL: ${{ secrets.RPC_URL }}
run: forge test -${{ inputs.test-verbosity }}
TEST_VERBOSITY: ${{ inputs.test-verbosity }}
run: forge test "-$TEST_VERBOSITY"

slither:
name: Slither Analysis
Expand All @@ -244,8 +254,10 @@ jobs:

- name: Install dependencies
if: inputs.package-manager != 'none'
env:
PACKAGE_MANAGER: ${{ inputs.package-manager }}
run: |
case "${{ inputs.package-manager }}" in
case "$PACKAGE_MANAGER" in
npm) npm ci ;;
yarn) yarn --frozen-lockfile ;;
pnpm) corepack enable && pnpm install --frozen-lockfile ;;
Expand Down Expand Up @@ -295,8 +307,10 @@ jobs:

- name: Install dependencies
if: inputs.package-manager != 'none'
env:
PACKAGE_MANAGER: ${{ inputs.package-manager }}
run: |
case "${{ inputs.package-manager }}" in
case "$PACKAGE_MANAGER" in
npm) npm ci ;;
yarn) yarn --frozen-lockfile ;;
pnpm) corepack enable && pnpm install --frozen-lockfile ;;
Expand All @@ -308,9 +322,10 @@ jobs:
- name: Run coverage
env:
RPC_URL: ${{ secrets.RPC_URL }}
COVERAGE_EXCLUDE_PATHS: ${{ inputs.coverage-exclude-paths }}
run: |
if [[ -n "${{ inputs.coverage-exclude-paths }}" ]]; then
forge coverage --no-match-path "${{ inputs.coverage-exclude-paths }}" 2>&1 | tee coverage-raw.txt
if [[ -n "$COVERAGE_EXCLUDE_PATHS" ]]; then
forge coverage --no-match-path "$COVERAGE_EXCLUDE_PATHS" 2>&1 | tee coverage-raw.txt
else
forge coverage 2>&1 | tee coverage-raw.txt
fi
Expand Down Expand Up @@ -362,8 +377,10 @@ jobs:

- name: Install dependencies
if: inputs.package-manager != 'none'
env:
PACKAGE_MANAGER: ${{ inputs.package-manager }}
run: |
case "${{ inputs.package-manager }}" in
case "$PACKAGE_MANAGER" in
npm) npm ci ;;
yarn) yarn --frozen-lockfile ;;
pnpm) corepack enable && pnpm install --frozen-lockfile ;;
Expand Down Expand Up @@ -415,8 +432,10 @@ jobs:

- name: Install dependencies
if: inputs.package-manager != 'none'
env:
PACKAGE_MANAGER: ${{ inputs.package-manager }}
run: |
case "${{ inputs.package-manager }}" in
case "$PACKAGE_MANAGER" in
npm) npm ci ;;
yarn) yarn --frozen-lockfile ;;
pnpm) corepack enable && pnpm install --frozen-lockfile ;;
Expand Down Expand Up @@ -478,8 +497,10 @@ jobs:

- name: Install dependencies
if: inputs.package-manager != 'none'
env:
PACKAGE_MANAGER: ${{ inputs.package-manager }}
run: |
case "${{ inputs.package-manager }}" in
case "$PACKAGE_MANAGER" in
npm) npm ci ;;
yarn) yarn --frozen-lockfile ;;
pnpm) corepack enable && pnpm install --frozen-lockfile ;;
Expand All @@ -490,17 +511,20 @@ jobs:
PRIVATE_KEY: ${{ secrets.PRIVATE_KEY }}
RPC_URL: ${{ secrets.RPC_URL }}
DEPLOY_ENV_VARS: ${{ secrets.DEPLOY_ENV_VARS }}
DEPLOY_SCRIPT: ${{ inputs.deploy-script }}
run: |
source .etherform/scripts/deploy/prepare-env.sh
forge script "${{ inputs.deploy-script }}" \
forge script "$DEPLOY_SCRIPT" \
--rpc-url "$RPC_URL" \
--private-key "$PRIVATE_KEY" \
--broadcast \
--slow \
-vvvv

- name: Wait for indexing
run: sleep ${{ inputs.indexing-wait }}
env:
INDEXING_WAIT: ${{ inputs.indexing-wait }}
run: sleep "$INDEXING_WAIT"

- name: Parse deployment addresses
id: parse
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/_upgrade-safety.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,10 @@ jobs:

- name: Install dependencies
if: inputs.package-manager != 'none'
env:
PACKAGE_MANAGER: ${{ inputs.package-manager }}
run: |
case "${{ inputs.package-manager }}" in
case "$PACKAGE_MANAGER" in
npm) npm ci ;;
yarn) yarn --frozen-lockfile ;;
pnpm) corepack enable && pnpm install --frozen-lockfile ;;
Expand Down