ci: pass inputs via env: instead of templating into run blocks#48
Draft
rubydusa wants to merge 1 commit into
Draft
ci: pass inputs via env: instead of templating into run blocks#48rubydusa wants to merge 1 commit into
rubydusa wants to merge 1 commit into
Conversation
GitHub Actions templates ${{ inputs.X }} substitutions before the shell
parses, so quoting in the script does not protect against values
containing ", $, backticks, or newlines. Convert every input
substitution inside run: blocks to the env: + quoted-shell-variable
pattern across all four workflows.
Behavior is unchanged for well-formed inputs; misbehaved inputs now
fail closed in the shell rather than escaping out of templating.
Closes #42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42.
Summary
Sweep every workflow and convert `${{ inputs.X }}` substitutions inside `run:` blocks to the `env:` + quoted-shell-variable pattern.
Why
GitHub Actions templates substitutions before the shell parses, so quoting in the script does not protect against values containing `"`, `$`, backticks, or newlines. Per GitHub's hardening guide, the recommended pattern is to pass via `env:` and reference `"$VAR"` in the script.
Files touched
`${{ steps.X.outputs.Y }}` references inside `run:` blocks (e.g. `mkdir -p deployments/${{ steps.network.outputs.network_name }}` in `_deploy-testnet.yml`) are kept as-is — they're driven by our own scripts, not consumer-controlled inputs. Lower priority and out of scope here.
Test plan
🤖 Generated with Claude Code