Skip to content

Add domestic futures/options API coverage#13

Merged
Bogyie merged 5 commits into
bog-220-kis-sdkfrom
issue/BOG-247-domestic-futures-options-coverage
May 30, 2026
Merged

Add domestic futures/options API coverage#13
Bogyie merged 5 commits into
bog-220-kis-sdkfrom
issue/BOG-247-domestic-futures-options-coverage

Conversation

@Bogyie

@Bogyie Bogyie commented May 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add domain-scoped domestic futures/options inventory API entry points covering 44 operation ids across trading/account, quotation, and realtime quotation collections.
  • Expose operation id constants and scoped validation so non-domain operation ids fail before network I/O.
  • Extend SDK core tests and docs/report coverage notes for the new domestic futures/options surface and existing safety gates.

Verification

  • cargo test --locked domestic_futures_options -- --nocapture passed in QA.
  • cargo test --locked passed in QA, including mock contract tests, SDK core tests, and doctests.
  • cargo fmt --check passed in QA.
  • cargo clippy --all-targets -- -D warnings passed in QA.
  • git diff --check passed locally before commit and in QA.
  • QA independently parsed inventory collections and confirmed all 44 operation ids match src/apis/domestic_futures_options.rs constants.

Safety and Scope

  • Live KIS API calls, real credentials, and actual order execution were not exercised.
  • Order-changing endpoints retain explicit TR ID selection requirements and local LiveTradingDisabled protection for real trading mutations.
  • Repository contribution files checked: README.md, Cargo.toml, docs/mock-server/README.md, .github/workflows/publish-crates.yml; no PR template, CONTRIBUTING, CODEOWNERS, SECURITY, or license file was present.

Co-authored-by: multica-agent <github@multica.ai>

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Complete

This PR successfully adds domestic futures/options API coverage with 44 operation IDs across trading/account, quotation, and realtime quotation collections. The implementation is solid with comprehensive safety mechanisms and test coverage.

Key strengths:

  • Domain-scoped validation prevents incorrect operation IDs from reaching network I/O
  • Trading mutations retain LiveTradingDisabled protection in real environments
  • Ambiguous TR IDs require explicit override, preventing misconfiguration
  • Comprehensive test suite covers validation, safety guards, and mock execution
  • Documentation accurately reflects new capabilities

Verification:
All tests pass according to the PR description, including:

  • cargo test --locked domestic_futures_options
  • cargo test --locked (full suite)
  • cargo fmt --check and cargo clippy

The code follows established patterns from the existing domestic stock implementation and maintains consistency with the SDK's safety-first design. No blocking issues identified.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

Bogyie added 4 commits May 30, 2026 09:03
…247-domestic-futures-options-coverage

# Conflicts:
#	README.md
…247-domestic-futures-options-coverage

# Conflicts:
#	README.md
#	docs/contract-quality-report.md
#	docs/usage.md
#	src/apis.rs
#	tests/sdk_core.rs
…247-domestic-futures-options-coverage

# Conflicts:
#	docs/usage.md
@Bogyie Bogyie merged commit 4320bd9 into bog-220-kis-sdk May 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant