Add overseas stock endpoint coverage#15
Conversation
Co-authored-by: multica-agent <github@multica.ai>
There was a problem hiding this comment.
This PR successfully adds overseas stock endpoint coverage to the SDK. The implementation is well-structured with 51 endpoints organized across 4 collections (trading/account, quotation, market-analysis, and realtime-quotation), following the existing domestic stock patterns.
The changes include proper safety mechanisms (live trading blocks, TR ID ambiguity handling, validation before network I/O), comprehensive test coverage with 7 new test cases, and clear documentation updates in both README and usage guide. All tests pass as reported in the PR description.
The code is ready to merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
…247-overseas-stock-coverage # Conflicts: # README.md # src/apis.rs # tests/sdk_core.rs
…247-overseas-stock-coverage # Conflicts: # README.md # docs/usage.md # tests/sdk_core.rs
…247-overseas-stock-coverage # Conflicts: # docs/usage.md # tests/sdk_core.rs
…247-overseas-stock-coverage # Conflicts: # README.md # docs/usage.md
Summary
execute_overseas_stockhelper so callers can use stable SDK handles instead of raw operation ids.bog-220-kis-sdkintegration branch and preserve all already-merged sibling coverage: OAuth revoke/approval, overseas futures/options, realtime stock, listed bond, domestic stock REST, and domestic futures/options.Verification
git diff --checkpassed locally before the original commit.cargo fmt --checkpassed.cargo test --lockedpassed: mock contract 4 passed, sdk_core 20 passed, doctest 0 passed.cargo clippy --all-targets -- -D warningspassed.cargo fmt --check,cargo test --locked(mock contract 4, sdk_core 25, doctest 0), andcargo clippy --all-targets -- -D warningspassed locally.cargo fmt --check,cargo test --locked(mock contract 4, sdk_core 29, doctest 0), andcargo clippy --all-targets -- -D warningspassed locally.cargo fmt --check,cargo test --locked(mock contract 4, sdk_core 36, doctest 0), andcargo clippy --all-targets -- -D warningspassed locally.cargo fmt --check,cargo test --locked(mock contract 4, sdk_core 42, doctest 0), andcargo clippy --all-targets -- -D warningspassed locally.QA Evidence
KisError::LiveTradingDisabledbefore network I/O.Reviews
Notes
README.md,Cargo.toml, and.github/workflows/publish-crates.ymlfor contribution-relevant rules.Closes BOG-252.