ODBC Test Segfault Fix - #54
Merged
Merged
Conversation
This reverts commit bae63ab.
Error: ``` [ RUN ] FlightSQLODBCTestBase/0.TestSQLGetConnectAttrTraceFileDMOnly unknown file: Failure C++ exception with description "wstring_convert: to_bytes error" thrown in the test body. ```
Author
|
Closing test PR |
If seg fault issue goes away, the error is likely from connection attribute tests
And enable connection attribute tests again
Only TestSQLSetConnectAttrAsyncDbcEventUnsupported is enabled, see if seg fault occurs
see if moving test to connection_test resolves the seg fault issue
The ConnectAttr tests are copied without any changes.
add dummy test to see if seg fault is invoked without driver usage; Trying to see if just adding one test in a separate file from connection_test.cc reproduces the issue
So connection_test.cc doesn't have same name as test executable
alinaliBQ
commented
Jun 20, 2025
rscales
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing ODBC test seg fault error exclusively on GitHub Actions. All tests pass but at the end it says
SegFault. Example log. Unable to reproduce it in my local environment with msys2 shell.the error is seemingly caused by this:
solution below solves the issue:
CMakeLists.txtThe root cause is unclear to me, and also I wasn't seeing this seg fault issue last week until I rebased from arrow's main branch.