Implement SQLGetInfo - #53
Merged
Merged
Conversation
alinaliBQ
reviewed
Jun 19, 2025
alinaliBQ
left a comment
alinaliBQ
left a comment
There was a problem hiding this comment.
These are the comments I have so far. I see some things that we discussed during standup, so I trust you to make those changes and I have skipped the comments on these.
|
JFYI - If you see segfault issues in workflows, it might not be related to your PR, I am fixing it in #54 |
alinaliBQ
reviewed
Jun 24, 2025
alinaliBQ
left a comment
alinaliBQ
left a comment
There was a problem hiding this comment.
LGTM, will review again after we have the changes for the last 5 attributes
alinaliBQ
reviewed
Jun 25, 2025
alinaliBQ
left a comment
alinaliBQ
left a comment
There was a problem hiding this comment.
pls fix the merge conflicts and run workflows
alinaliBQ
reviewed
Jun 25, 2025
alinaliBQ
reviewed
Jun 25, 2025
rscales
marked this pull request as ready for review
June 25, 2025 23:52
jduo
reviewed
Jun 26, 2025
alinaliBQ
reviewed
Jun 26, 2025
alinaliBQ
left a comment
alinaliBQ
left a comment
There was a problem hiding this comment.
I have put suggestions for the values that the driver is returning, I found them at GetInfoCache constructor.
alinaliBQ
reviewed
Jun 26, 2025
Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
alinaliBQ
reviewed
Jun 26, 2025
Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement SQLGetInfo