Reuse connections across test suite - #173
Closed
justing-bq wants to merge 1 commit into
Closed
Conversation
justing-bq
force-pushed
the
reuseTestConnections
branch
from
April 17, 2026 00:31
f5a8910 to
87be896
Compare
Merged
Author
|
Change included in #168 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We avoid crashing tests on Linux if we minimize the number of connect/disconnect attempts. So now we are reusing the same connection as much as possible throughout the tests.
What changes are included in this PR?
All our necessary connections happen during global
SetUp()and then they get disconnected during globalTearDown().Test Fixture SetUp is now about updating pointers to the correct environment, connection, and statement handles for those tests.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.