Fix tests on Linux - #168
Merged
Merged
Conversation
justing-bq
force-pushed
the
fix-linux-tests
branch
4 times, most recently
from
April 10, 2026 16:56
f3ef499 to
53eae43
Compare
alinaliBQ
reviewed
Apr 10, 2026
justing-bq
force-pushed
the
fix-linux-tests
branch
6 times, most recently
from
April 13, 2026 20:58
6b4bfe6 to
584dca8
Compare
alinaliBQ
reviewed
Apr 14, 2026
alinaliBQ
reviewed
Apr 14, 2026
justing-bq
force-pushed
the
fix-linux-tests
branch
4 times, most recently
from
April 17, 2026 00:43
ae29f34 to
b2e73b6
Compare
justing-bq
marked this pull request as ready for review
April 17, 2026 02:52
Co-Authored-By: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
justing-bq
force-pushed
the
fix-linux-tests
branch
from
April 17, 2026 17:33
b2e73b6 to
d4bdb26
Compare
alinaliBQ
reviewed
Apr 17, 2026
| } | ||
|
|
||
| #ifdef SQL_DRIVER_AWARE_POOLING_SUPPORTED | ||
| # ifndef __linux__ |
There was a problem hiding this comment.
Let's add comment
On Linux, unix-odbc doesn't support SQL_DRIVER_AWARE_POOLING_SUPPORTED
I assume this is the reason we are disabling this test for Linux
Author
There was a problem hiding this comment.
I've looked into this a bit more and discovered that (unlike the Windows and Mac driver managers) unixODBC hands off this attribute to the driver. But our driver does not have any SQLGetInfo logic for SQL_DRIVER_AWARE_POOLING_SUPPORTED.
I will create a ticket for this issue and mention it in a comment here.
justing-bq
force-pushed
the
fix-linux-tests
branch
from
April 17, 2026 19:09
d4bdb26 to
ff738ba
Compare
justing-bq
force-pushed
the
fix-linux-tests
branch
from
April 17, 2026 19:24
ff738ba to
14c3de1
Compare
justing-bq
force-pushed
the
fix-linux-tests
branch
from
April 17, 2026 19:31
14c3de1 to
2832880
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We want our tests passing on Linux.
What changes are included in this PR?
Miscellaneous fixes.
Depends on #173
Are these changes tested?
Yes.
Are there any user-facing changes?
No.