Skip to content

Define Test Fixtures #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justing-bq merged 2 commits into from
Oct 20, 2025
Merged

Define Test Fixtures #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c47fa43
Connect/disconnect in SetUp/TearDown
justing-bq Oct 16, 2025
d982771
Define Test Fixtures
justing-bq Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
305 changes: 75 additions & 230 deletions cpp/src/arrow/flight/sql/odbc/tests/columns_test.cc
View file
Open in desktop

Large diffs are not rendered by default.

217 changes: 45 additions & 172 deletions cpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
View file
Open in desktop

Large diffs are not rendered by default.

962 changes: 169 additions & 793 deletions cpp/src/arrow/flight/sql/odbc/tests/connection_info_test.cc
View file
Open in desktop

Large diffs are not rendered by default.

77 changes: 34 additions & 43 deletions cpp/src/arrow/flight/sql/odbc/tests/connection_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,17 @@
#include <gtest/gtest.h>

namespace arrow::flight::sql::odbc {

template <typename T>
class ConnectionTest : public T {
public:
using List = std::list<T>;
};

class ConnectionRemoteTest : public FlightSQLODBCRemoteTestBase {};
using TestTypes = ::testing::Types<FlightSQLODBCMockTestBase, ConnectionRemoteTest>;
TYPED_TEST_SUITE(ConnectionTest, TestTypes);

TEST(SQLAllocHandle, TestSQLAllocHandleEnv) {
SQLHENV env;

Expand Down Expand Up @@ -93,16 +104,20 @@ TEST(SQLFreeHandle, TestSQLFreeHandleConnect) {
ASSERT_EQ(SQL_SUCCESS, SQLFreeHandle(SQL_HANDLE_DBC, conn));
}

TYPED_TEST(FlightSQLODBCTestBase, TestFreeNullHandles) {
TEST(SQLFreeHandle, TestFreeNullHandles) {
SQLHENV env = NULL;
SQLHDBC conn = NULL;
SQLHSTMT stmt = NULL;

// Verifies attempt to free invalid handle does not cause segfault
// Attempt to free null statement handle
ASSERT_EQ(SQL_INVALID_HANDLE, SQLFreeHandle(SQL_HANDLE_STMT, this->stmt));
ASSERT_EQ(SQL_INVALID_HANDLE, SQLFreeHandle(SQL_HANDLE_STMT, stmt));

// Attempt to free null connection handle
ASSERT_EQ(SQL_INVALID_HANDLE, SQLFreeHandle(SQL_HANDLE_DBC, this->conn));
ASSERT_EQ(SQL_INVALID_HANDLE, SQLFreeHandle(SQL_HANDLE_DBC, conn));

// Attempt to free null environment handle
ASSERT_EQ(SQL_INVALID_HANDLE, SQLFreeHandle(SQL_HANDLE_ENV, this->env));
ASSERT_EQ(SQL_INVALID_HANDLE, SQLFreeHandle(SQL_HANDLE_ENV, env));
}

TEST(SQLFreeConnect, TestSQLFreeConnect) {
Expand Down Expand Up @@ -154,42 +169,30 @@ TEST(SQLSetEnvAttr, TestSQLSetEnvAttrODBCVersionInvalid) {
SQLSetEnvAttr(env, SQL_ATTR_ODBC_VERSION, reinterpret_cast<void*>(1), 0));
}

TYPED_TEST(FlightSQLODBCTestBase, TestSQLGetEnvAttrOutputNTS) {
this->Connect();

TYPED_TEST(ConnectionTest, TestSQLGetEnvAttrOutputNTS) {
SQLINTEGER output_nts;

ASSERT_EQ(SQL_SUCCESS,
SQLGetEnvAttr(this->env, SQL_ATTR_OUTPUT_NTS, &output_nts, 0, 0));

ASSERT_EQ(SQL_TRUE, output_nts);

this->Disconnect();
}

TYPED_TEST(FlightSQLODBCTestBase, DISABLED_TestSQLGetEnvAttrGetLength) {
TYPED_TEST(ConnectionTest, DISABLED_TestSQLGetEnvAttrGetLength) {
// Test is disabled because call to SQLGetEnvAttr is handled by the driver manager on
// Windows. This test case can be potentially used on macOS/Linux
this->Connect();

SQLINTEGER length;
ASSERT_EQ(SQL_SUCCESS,
SQLGetEnvAttr(this->env, SQL_ATTR_ODBC_VERSION, nullptr, 0, &length));

EXPECT_EQ(sizeof(SQLINTEGER), length);

this->Disconnect();
}

TYPED_TEST(FlightSQLODBCTestBase, DISABLED_TestSQLGetEnvAttrNullValuePointer) {
TYPED_TEST(ConnectionTest, DISABLED_TestSQLGetEnvAttrNullValuePointer) {
// Test is disabled because call to SQLGetEnvAttr is handled by the driver manager on
// Windows. This test case can be potentially used on macOS/Linux
this->Connect();

ASSERT_EQ(SQL_ERROR,
SQLGetEnvAttr(this->env, SQL_ATTR_ODBC_VERSION, nullptr, 0, nullptr));

this->Disconnect();
}

TEST(SQLSetEnvAttr, TestSQLSetEnvAttrOutputNTSValid) {
Expand Down Expand Up @@ -224,7 +227,7 @@ TEST(SQLSetEnvAttr, TestSQLSetEnvAttrNullValuePointer) {
ASSERT_EQ(SQL_ERROR, SQLSetEnvAttr(env, SQL_ATTR_ODBC_VERSION, nullptr, 0));
}

TYPED_TEST(FlightSQLODBCTestBase, TestSQLDriverConnect) {
TYPED_TEST(ConnectionTest, TestSQLDriverConnect) {
SQLHENV env;
SQLHDBC conn;

Expand Down Expand Up @@ -283,7 +286,7 @@ TYPED_TEST(FlightSQLODBCTestBase, TestSQLDriverConnect) {
}

#if defined _WIN32 || defined _WIN64
TYPED_TEST(FlightSQLODBCTestBase, TestSQLDriverConnectDsn) {
TYPED_TEST(ConnectionTest, TestSQLDriverConnectDsn) {
SQLHENV env;
SQLHDBC conn;

Expand Down Expand Up @@ -346,7 +349,7 @@ TYPED_TEST(FlightSQLODBCTestBase, TestSQLDriverConnectDsn) {
ASSERT_EQ(SQL_SUCCESS, SQLFreeHandle(SQL_HANDLE_ENV, env));
}

TYPED_TEST(FlightSQLODBCTestBase, TestSQLConnect) {
TYPED_TEST(ConnectionTest, TestSQLConnect) {
SQLHENV env;
SQLHDBC conn;

Expand Down Expand Up @@ -405,7 +408,7 @@ TYPED_TEST(FlightSQLODBCTestBase, TestSQLConnect) {
ASSERT_EQ(SQL_SUCCESS, SQLFreeHandle(SQL_HANDLE_ENV, env));
}

TEST_F(FlightSQLODBCRemoteTestBase, TestSQLConnectInputUidPwd) {
TEST_F(ConnectionRemoteTest, TestSQLConnectInputUidPwd) {
SQLHENV env;
SQLHDBC conn;

Expand Down Expand Up @@ -473,7 +476,7 @@ TEST_F(FlightSQLODBCRemoteTestBase, TestSQLConnectInputUidPwd) {
ASSERT_EQ(SQL_SUCCESS, SQLFreeHandle(SQL_HANDLE_ENV, env));
}

TEST_F(FlightSQLODBCRemoteTestBase, TestSQLConnectInvalidUid) {
TEST_F(ConnectionRemoteTest, TestSQLConnectInvalidUid) {
SQLHENV env;
SQLHDBC conn;

Expand Down Expand Up @@ -530,7 +533,7 @@ TEST_F(FlightSQLODBCRemoteTestBase, TestSQLConnectInvalidUid) {
ASSERT_EQ(SQL_SUCCESS, SQLFreeHandle(SQL_HANDLE_ENV, env));
}

TEST_F(FlightSQLODBCRemoteTestBase, TestSQLConnectDSNPrecedence) {
TEST_F(ConnectionRemoteTest, TestSQLConnectDSNPrecedence) {
SQLHENV env;
SQLHDBC conn;

Expand Down Expand Up @@ -594,7 +597,7 @@ TEST_F(FlightSQLODBCRemoteTestBase, TestSQLConnectDSNPrecedence) {

#endif

TEST_F(FlightSQLODBCRemoteTestBase, TestSQLDriverConnectInvalidUid) {
TEST_F(ConnectionRemoteTest, TestSQLDriverConnectInvalidUid) {
SQLHENV env;
SQLHDBC conn;

Expand Down Expand Up @@ -661,14 +664,11 @@ TEST(SQLDisconnect, TestSQLDisconnectWithoutConnection) {
ASSERT_EQ(SQL_SUCCESS, SQLFreeHandle(SQL_HANDLE_ENV, env));
}

TYPED_TEST(FlightSQLODBCTestBase, TestConnect) {
TYPED_TEST(ConnectionTest, TestConnect) {
// Verifies connect and disconnect works on its own
this->Connect();
this->Disconnect();
}

TYPED_TEST(FlightSQLODBCTestBase, TestSQLAllocFreeStmt) {
this->Connect();
TYPED_TEST(ConnectionTest, TestSQLAllocFreeStmt) {
SQLHSTMT statement;

// Allocate a statement using alloc statement
Expand All @@ -682,11 +682,9 @@ TYPED_TEST(FlightSQLODBCTestBase, TestSQLAllocFreeStmt) {

// Free statement handle
ASSERT_EQ(SQL_SUCCESS, SQLFreeStmt(statement, SQL_DROP));

this->Disconnect();
}

TYPED_TEST(FlightSQLODBCTestBase, TestCloseConnectionWithOpenStatement) {
TYPED_TEST(ConnectionTest, TestCloseConnectionWithOpenStatement) {
SQLHENV env;
SQLHDBC conn;
SQLHSTMT statement;
Expand Down Expand Up @@ -728,22 +726,17 @@ TYPED_TEST(FlightSQLODBCTestBase, TestCloseConnectionWithOpenStatement) {
ASSERT_EQ(SQL_SUCCESS, SQLFreeHandle(SQL_HANDLE_ENV, env));
}

TYPED_TEST(FlightSQLODBCTestBase, TestSQLAllocFreeDesc) {
this->Connect();
TYPED_TEST(ConnectionTest, TestSQLAllocFreeDesc) {
SQLHDESC descriptor;

// Allocate a descriptor using alloc handle
ASSERT_EQ(SQL_SUCCESS, SQLAllocHandle(SQL_HANDLE_DESC, this->conn, &descriptor));

// Free descriptor handle
ASSERT_EQ(SQL_SUCCESS, SQLFreeHandle(SQL_HANDLE_DESC, descriptor));

this->Disconnect();
}

TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetStmtAttrDescriptor) {
this->Connect();

TYPED_TEST(ConnectionTest, TestSQLSetStmtAttrDescriptor) {
SQLHDESC apd_descriptor, ard_descriptor;

// Allocate an APD descriptor using alloc handle
Expand Down Expand Up @@ -798,8 +791,6 @@ TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetStmtAttrDescriptor) {
SQLGetStmtAttr(this->stmt, SQL_ATTR_APP_ROW_DESC, &value, sizeof(value), 0));

EXPECT_EQ(internal_ard, value);

this->Disconnect();
}

} // namespace arrow::flight::sql::odbc
Loading
Loading