Define Test Fixtures - #123
Merged
Merged
Conversation
justing-bq
marked this pull request as ready for review
October 16, 2025 16:37
justing-bq
force-pushed
the
setupTeardown
branch
from
October 16, 2025 16:56
2222e8b to
995a5b9
Compare
alinaliBQ
reviewed
Oct 16, 2025
alinaliBQ
left a comment
alinaliBQ
left a comment
There was a problem hiding this comment.
On my machine I found these tests failing, pls check:
[ FAILED ] 5 tests, listed below:
[ FAILED ] FlightSQLODBCTestBase/0.TestFreeNullHandles, where TypeParam = arrow::flight::sql::odbc::FlightSQLODBCMockTestBase
[ FAILED ] FlightSQLODBCTestBase/1.TestFreeNullHandles, where TypeParam = arrow::flight::sql::odbc::FlightSQLODBCRemoteTestBase
[ FAILED ] FlightSQLODBCMockTestBase.TestSQLGetTypeInfoTimeODBCVer2
[ FAILED ] FlightSQLODBCMockTestBase.TestSQLGetTypeInfoSQLTypeTimeODBCVer2
[ FAILED ] FlightSQLODBCMockTestBase.TestSQLGetTypeInfoSQLTimestampODBCVer2
5 FAILED TESTS
alinaliBQ
force-pushed
the
apache-odbc
branch
from
October 16, 2025 18:02
f36d7e9 to
2c6d590
Compare
justing-bq
force-pushed
the
setupTeardown
branch
from
October 16, 2025 18:45
995a5b9 to
686f74c
Compare
alinaliBQ
reviewed
Oct 17, 2025
justing-bq
force-pushed
the
setupTeardown
branch
from
October 17, 2025 17:02
686f74c to
0628120
Compare
^ Conflicts: ^ cpp/src/arrow/flight/sql/odbc/tests/connection_test.cc
justing-bq
force-pushed
the
setupTeardown
branch
from
October 17, 2025 22:57
92a35c3 to
d982771
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We want test fixtures for each test file.
What changes are included in this PR?
Test Fixtures are added for each test file.
Connect & disconnect is moved to the fixture's
SetUp()/Teardown()methods.Are these changes tested?
Yes.
Are there any user-facing changes?
No.