Precondition Node should run children to completion before checking it's if statement again #904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran across an issue where a Precondition's "if" statement was evaluating from
true
tofalse
while it's children were still executing. This resulted in the children only executing partway before the Precondition node short circuited the tree by returning the value of the "else" port unexpectedly.For a more concrete example, suppose I want to implement a "RunOnce" behavior as a subtree, the xml would look like the following:
Over multiple ticks of
SomeLongRunningAction
this will shortcircuit returnFAILURE
from the "else" ofPrecondition
. This PR would allow forSomeLongRunningAction
(and any other following nodes that are children ofPrecondition
) to run to Completion.