Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Camera Defaults with more Robust Defaults #167

Closed
wants to merge 1 commit into from
Closed

Replace Camera Defaults with more Robust Defaults #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Basis/Packages/com.basis.framework/Drivers/BasisLocalCameraDriver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public class BasisLocalCameraDriver : MonoBehaviour
public UniversalAdditionalCameraData CameraData;
public SteamAudio.SteamAudioListener SteamAudioListener;
public BasisLocalPlayer LocalPlayer;
public int DefaultCameraFov = 90;
public int DefaultCameraFov = 60;
// Static event to notify when the instance exists
public static event System.Action InstanceExists;
public BasisLockToInput BasisLockToInput;
Expand All @@ -41,7 +41,8 @@ public class BasisLocalCameraDriver : MonoBehaviour
public AudioClip MuteSound;
public AudioClip UnMuteSound;
public AudioSource AudioSource;
public float NearClip = 0.001f;
public float NearClip = 0.02f;
public float farClip = 3000.0f;
private Coroutine scaleCoroutine;

public Vector3 StartingScale = Vector3.zero;
Expand All @@ -62,7 +63,7 @@ public void OnEnable()
HasInstance = true;
}
Camera.nearClipPlane = NearClip;
Camera.farClipPlane = 1500;
Camera.farClipPlane = farClip;
CameraInstanceID = Camera.GetInstanceID();
//fire static event that says the instance exists
OnHeightChanged();
Expand Down
Loading