Replace Camera Defaults with more Robust Defaults #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the far-clip to be much further out and adjust the near-clip to compensate, should still be close enough for almost all cases. Fix the "Quake 3 Arena"-esque default FoV with a more normal looking camera FoV.
|
The role of BasisSceneFactory is to set the camera settings; as such, I don't see how changing these values is a good idea, especially the near clip, which will cause issues. I think adding FOV as an option in the settings panel is something that can be done. (edit done so will be on main in the next few days) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the far-clip to be much further out and adjust the near-clip to compensate, should still be close enough for almost all cases.
Fix the "Quake 3 Arena"-esque default FoV with a more normal looking camera FoV.
Also expose the farClip value so it can be easily adjusted.