Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitespace autofix stuff, and shfmt cleanup #2265

Merged
merged 9 commits into from
Jan 25, 2025

Conversation

seefood
Copy link
Contributor

@seefood seefood commented Nov 7, 2024

Description

ran global whitespace fixes as prep for cleanup

Motivation and Context

might help get the cleanup project a push, as it has been simmering for too long :)

How Has This Been Tested?

Just locally and blind trust of the tests we run in pre-commit.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Sorry, something went wrong.

Ira Abramov added 3 commits November 7, 2024 12:03
* master:
  linting the bats
  linting the bats
  lint cleanup for shfmt
  test: add new lib files to `setup_libs()`
  test_helper: make lib loading default
  tests: add to `clean_files.txt`
  test/install: `shellcheck`
  test/plugin: `shellcheck`
  test/completion: `shellcheck`
  test/bash_it: `shellcheck`
  test/theme: `shellcheck`
  test/lib: `shellcheck`
  BATS: require `shellcheck` on test files
* master: (41 commits)
  no need to test so many versions, just the newest and oldest, I think?
  First attempt: just a naiive upgrade of BATS
  you go "quote-TOAH" on that thang!
  ironing this odd lint problem
  ironing this odd lint problem
  Allow setting git current user and add a default icon
  shfmt and shellcheck, docker-compose.completion is ready
  shfmt and shellcheck, dirs.completion is ready
  some compgen tricks are just too complex to write "by the rules"
  also check on latest ubuntu
  fixing plugins/available/sudo.plugin.bash
  fixing plugins/available/thefuck.plugin.bash
  fixing plugins/available/virtualenv.plugin.bash
  fixing plugins/available/z_autoenv.plugin.bash
  fixing bundler
  fixing salt
  fixing gradle
  fixing docker-compose.plugin.bash
  I guess this needs to be fixed to pass the tests...
  Start checking one newer macos, the old versions are getting irrelevant
  ...
themes/doubletime/doubletime.theme.bash Fixed Show fixed Hide fixed
themes/doubletime/doubletime.theme.bash Fixed Show fixed Hide fixed
themes/doubletime/doubletime.theme.bash Fixed Show fixed Hide fixed
themes/doubletime/doubletime.theme.bash Fixed Show fixed Hide fixed
themes/doubletime/doubletime.theme.bash Fixed Show fixed Hide fixed
themes/rjorgenson/rjorgenson.theme.bash Fixed Show fixed Hide fixed
Ira Abramov added 4 commits January 22, 2025 16:22
…nto ira/pre-commit-cleanup

* 'ira/pre-commit-cleanup' of github.com:seefood/bash-it:
  security suggestion from github
@seefood seefood marked this pull request as ready for review January 22, 2025 14:56
@seefood seefood merged commit 44623ff into Bash-it:master Jan 25, 2025
7 checks passed
@seefood seefood deleted the ira/pre-commit-cleanup branch January 25, 2025 18:21
@akinomyoga akinomyoga mentioned this pull request Jan 27, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant