Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup even more plugins #2282

Merged
merged 20 commits into from
Jan 29, 2025
Merged

Cleanup even more plugins #2282

merged 20 commits into from
Jan 29, 2025

Conversation

seefood
Copy link
Contributor

@seefood seefood commented Jan 25, 2025 •
edited
Loading

Description

shfmt and shellcheck cleanups

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 25, 2025
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShellCheck found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@seefood seefood marked this pull request as ready for review January 26, 2025 13:05
akinomyoga
akinomyoga reviewed Jan 26, 2025
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
akinomyoga
akinomyoga reviewed Jan 26, 2025
View reviewed changes
plugins/available/fzf.plugin.bash Outdated Show resolved Hide resolved
plugins/available/pack.plugin.bash Outdated Show resolved Hide resolved
plugins/available/pack.plugin.bash Outdated Show resolved Hide resolved
plugins/available/pack.plugin.bash Outdated Show resolved Hide resolved
vendor/github.com/rcaloras/bash-preexec/test/bash-preexec.bats Outdated Show resolved Hide resolved
akinomyoga
akinomyoga reviewed Jan 26, 2025
View reviewed changes
completion/available/sqlmap.completion.bash Outdated Show resolved Hide resolved
plugins/available/fzf.plugin.bash Outdated Show resolved Hide resolved
@seefood seefood requested a review from akinomyoga January 27, 2025 08:02
@seefood
Copy link
Contributor Author

seefood commented Jan 28, 2025

BTW, if anyone knows why it's still trying to test on macos-11 and ubuntu 22.04 even though I removed them, please let me know. I don't think that github has resources for running those tests anyway.

@akinomyoga we ready to merge?

@NoahGorny
Copy link
Member

BTW, if anyone knows why it's still trying to test on macos-11 and ubuntu 22.04 even though I removed them, please let me know. I don't think that github has resources for running those tests anyway.

@akinomyoga we ready to merge?

Its because its still considered as required for the PR to merge to master, disabling it now in the settings

akinomyoga
akinomyoga suggested changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akinomyoga we ready to merge?

Not really.

completion/available/sqlmap.completion.bash Show resolved Hide resolved
@seefood seefood merged commit c4baa6e into master Jan 29, 2025
12 of 13 checks passed
@seefood seefood deleted the ira/cleanup4 branch January 29, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akinomyoga akinomyoga akinomyoga approved these changes

Assignees
No one assigned
Labels
clean up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seefood @NoahGorny @akinomyoga