-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feature: add ota updates for omi glass #2692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# Make GitHub API request if not cached | ||
async with httpx.AsyncClient() as client: | ||
url = "https://api.github.com/repos/BasedHardware/omi/releases?per_page=100" | ||
url = "https://api.github.com/repos/kanishkatn/omi/releases?per_page=100" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url = "https://api.github.com/repos/kanishkatn/omi/releases?per_page=100" | |
url = "https://api.github.com/repos/basedhardware/omi/releases?per_page=100" |
@kanishkatn cool!!! i guess it works well. btw, what is this? > the photo capture is currently disabled. haha. also, could you clean up your PR a bit: 1/ the app already has the firmware download functionality - you don’t need to handle it, right? 2/ please check the app > lib > services > devices > omi_connection.dart for having a better way to handle the custom OTA BLE services. 3/ 4/ why do we need to change the partition? 5/ it’s omiglass, not openglass. also, remove the print logs etc. |
Hey @beastoin ! Thank you for taking a look!
There were few crashes related to memory access during the upload so I had to disable it. I can no longer re-create them and have reverted the changes.
I've only renamed the method here
I will take a look. Thanks.
That's a good idea! I will check if we could get the sender's config as well.
Using I've ensured that the
In the backend it is defined as I will remove all the debug logs. |
how's it going man, should i review the PR now? |
@kanishkatn any updates? |
Hey @beastoin @aaravgarg , Thank you for waiting! I was away for a while and will look into addressing the review comments in a couple of days. |
444e428
to
4d0a4eb
Compare
4d0a4eb
to
3c8f3f6
Compare
Hello @beastoin @aaravgarg , I have addressed the following in the commit
I've replaced the hardcoded chunkSize with a dynamic calculation. Here are the details
However, for the above feedback, I wasn't able to find a module/method that already handles OTA updates. The module used in this PR seems to be used for OTA updates on the omi necklace as well. If the feedback was to move the OTA updates completely to I have rebased the branch and have ensured that the OTA updates still work in my iPhone. Please let me know if you need any further inputs or assistance! |
OTA Firmware Updates for Omi Glass
Note: Tested only on iOS.
Changes
Flutter
OpenGlass Firmware
Testing
Demo
omiglass_ota_demo.mov
TODO