Skip to content

Added correct DNS zone registration #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gluip wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added correct DNS zone registration #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions Modules/privateEndpoint.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ param groupIds array = [
'blob'
]

var privateDnsZoneName = '${privateEndpointName}.blob.core.windows.net'
Copy link
Copy Markdown
Owner

@Ba4bes Ba4bes Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this line I would really like to keep privateEndpointName as a parameter to give more flexibility


var privateDNSZoneName = 'privatelink.blob.core.windows.net'

resource privateEndpoint 'Microsoft.Network/privateEndpoints@2020-11-01' = {
name: privateEndpointName
Expand All @@ -43,8 +43,33 @@ resource privateEndpoint 'Microsoft.Network/privateEndpoints@2020-11-01' = {
}
}

resource privateDnsZones 'Microsoft.Network/privateDnsZones@2020-06-01' = {
name: privateDnsZoneName
tags: tagValues
resource privateDnsZones 'Microsoft.Network/privateDnsZones@2018-09-01' = {
Copy link
Copy Markdown
Owner

@Ba4bes Ba4bes Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the api version back to the most recent one?

name: privateDNSZoneName
location: 'global'
}
properties: {}
}

resource privateDnsZoneLink 'Microsoft.Network/privateDnsZones/virtualNetworkLinks@2018-09-01' = {
name: '${privateDnsZones.name}/${privateDnsZones.name}-link'
location: 'global'
properties: {
registrationEnabled: false
virtualNetwork: {
id: vnetId
}
}
}
resource privateDnsZoneGroup 'Microsoft.Network/privateEndpoints/privateDnsZoneGroups@2020-06-01' = {
name: '${privateEndpoint.name}/dnsgroupname'
properties: {
privateDnsZoneConfigs: [
{
name: 'config1'
properties: {
privateDnsZoneId: privateDnsZones.id
}
}
]
}
}