Added correct DNS zone registration#1
Open
gluip wants to merge 1 commit into
Open
Conversation
Added DNS zone registration
gluip
changed the title
Ba4bes
requested changes
Jun 16, 2021
Owner
Ba4bes
left a comment
Ba4bes
left a comment
There was a problem hiding this comment.
Thank you for your work, apologies for the delay. If you could fix the two comments I've made, I will merge the PR 👍
| 'blob' | ||
| ] | ||
|
|
||
| var privateDnsZoneName = '${privateEndpointName}.blob.core.windows.net' |
Owner
There was a problem hiding this comment.
For this line I would really like to keep privateEndpointName as a parameter to give more flexibility
| resource privateDnsZones 'Microsoft.Network/privateDnsZones@2020-06-01' = { | ||
| name: privateDnsZoneName | ||
| tags: tagValues | ||
| resource privateDnsZones 'Microsoft.Network/privateDnsZones@2018-09-01' = { |
Owner
There was a problem hiding this comment.
Could you change the api version back to the most recent one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added DNS zone registration